Clamp dot in angle_between to avoid precision errors.

Fixes #3978
odin-lang · Jul 28, 2024 · 24e6f16 · 24e6f16
1 parent f852aac
commit 24e6f16
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/core/math/linalg/general.odin b/core/math/linalg/general.odin
@@ -275,7 +275,8 @@ to_ptr :: proc{vector_to_ptr, matrix_to_ptr}
 vector_angle_between :: proc "contextless" (a, b: $V/[$N]$E) -> E {
 	a0 := normalize0(a)
 	b0 := normalize0(b)
-	return math.acos(dot(a0, b0))
+	d  := clamp(dot(a0, b0), -1, +1)
+	return math.acos(d)
 }
 quaternion64_angle_between :: proc "contextless" (a, b: $Q/quaternion64) -> f16 {
 	c := normalize0(conj(a) * b)