Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs, CI build and CLI interface improvements #303

Closed
wants to merge 26 commits into from
Closed

Conversation

GDYendell
Copy link
Collaborator

@GDYendell GDYendell commented Sep 29, 2022

Waiting on #301

This change aims to make it easier for new developers to get started using odin-data. There are a few unrelated parts:

  • Docs with doxygen generated API
  • Fixing / simplifying the dummy example so it is can be run easily and reliably
  • Fix system tests that run in CI
  • Tear out a lot of frameProcessor CLI options superceded by the json config

Note that this branch requires the changes in #301, so includes those commits for now.

The docs are still very much a work in progress, but this adds the foundation to start adding to them. The keys things are:

  • There are a lot of warnings from the doxygen build about undocumented code
  • There should be more prose-with-API docs for the most important things to know
    • I started with the obvious classes, but probably not everything and I haven't written much description on how to use them.
  • Using the Python Tools is very out of date, but I have left because it is probably better to have it than not.
  • Code Climate is not providing any coverage information - I notice we use codecov for odin-control, which might be better
  • Diagrams to aid with descriptive parts
    • I would like to create some Excalidraw diagrams because they can be checked in to git and easily edited with a freely available web editor

@GDYendell
Copy link
Collaborator Author

@timcnicholls could you enable the docs build under Settings > Pages > Build and Deployment? Hopefully then it will run the build step. I am not sure if it will actually publish them until they are built on master.

@timcnicholls
Copy link
Contributor

@timcnicholls could you enable the docs build under Settings > Pages > Build and Deployment? Hopefully then it will run the build step. I am not sure if it will actually publish them until they are built on master.

@GDYendell Sure. Which mode do you want? Deploy from branch or Github Actions?

@GDYendell
Copy link
Collaborator Author

I think just Deploy from branch and then gh-pages. It uses this action to deploy it.

@GDYendell GDYendell force-pushed the docs-etc branch 2 times, most recently from d8f4e00 to e5c2507 Compare September 29, 2022 12:41
@GDYendell
Copy link
Collaborator Author

@GDYendell GDYendell force-pushed the docs-etc branch 3 times, most recently from a0db8bf to 9775f1a Compare November 15, 2022 22:04
@GDYendell GDYendell mentioned this pull request Nov 15, 2022
@GDYendell GDYendell force-pushed the docs-etc branch 3 times, most recently from eba913c to cec47a8 Compare November 24, 2022 20:46
@GDYendell
Copy link
Collaborator Author

This PR fixes a few existing issues. Check through and link them here.

@GDYendell
Copy link
Collaborator Author

Update references to SharedMemoryParser. Replaced with SharedMemoryManager in 9fc3b93

- Remove various command line arguments that should be configured in the json
  config file
- Fix name of file writer class to register shutdown callback with
- Erasing while iterating seems to cause seg faults in some cases
- Tidy App main and make FR and FP consistent
- Remove single-shot FrameProcessor argument - passing frames on startup makes it clear
  we should shutdown automatically and matches the frameReceiver API
- Rename datasetSize to shutdownFrameCount for clarity
- Add path and timeout period
- udp_packets_per_frame doesn't seem to matter, but that is the right
  number according to the debug logging in the fp (as is 8000 for size)
- Add frames config so fp and fr shut down
- Add packet-gap to make the test run reliably
- This was being parsed as a doc string for the FrameProcessor namespace
- Delete old doc directory
@GDYendell
Copy link
Collaborator Author

Add note that setting N frames = 0 means run until explicit stop.

@GDYendell
Copy link
Collaborator Author

GDYendell commented Feb 16, 2023

Check whether odin-data compiles with std=cxx11 compile flag

@GDYendell
Copy link
Collaborator Author

Superceded by #317, #318, #314

@GDYendell GDYendell closed this Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants