Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control panel styles and parts #10

Merged
merged 6 commits into from
Jan 4, 2024
Merged

Control panel styles and parts #10

merged 6 commits into from
Jan 4, 2024

Conversation

mirisuzanne
Copy link
Member

Related Issue(s)

Reminder to add related issue(s), if available.

I provided some basic styles for the control panel, but they could be improved. I'm also not sure if we want to make the entire panel replaceable, or if it's enough to replace the controls inside the panel. I suppose the advantage of replaceing the entire panel is that it could be more easily styled by the page.

Copy link

netlify bot commented Dec 28, 2023

Deploy Preview for slide-deck ready!

Name Link
🔨 Latest commit 5f74602
🔍 Latest deploy log https://app.netlify.com/sites/slide-deck/deploys/6596d001d5e9e20008935a74
😎 Deploy Preview https://deploy-preview-10--slide-deck.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mirisuzanne mirisuzanne linked an issue Jan 2, 2024 that may be closed by this pull request
@mirisuzanne mirisuzanne linked an issue Jan 2, 2024 that may be closed by this pull request
@mirisuzanne mirisuzanne requested a review from stacyk January 3, 2024 04:42
@mirisuzanne
Copy link
Member Author

@stacyk this isn't ready for a final review, but I could use your feedback on it before going further.

@mirisuzanne
Copy link
Member Author

Discussion this morning:

  • Make the entire control panel replaceable
  • Expose button parts for light dom style
  • Provide some default styles in the light dom css theme

@mirisuzanne mirisuzanne assigned mirisuzanne and unassigned stacyk Jan 3, 2024
@mirisuzanne mirisuzanne marked this pull request as ready for review January 3, 2024 21:00
@mirisuzanne mirisuzanne requested review from jamesnw and jerivas January 3, 2024 21:01
@mirisuzanne mirisuzanne assigned jamesnw, stacyk and jerivas and unassigned mirisuzanne Jan 3, 2024
@mirisuzanne
Copy link
Member Author

@jamesnw @jerivas @stacyk This should be ready for review, and makes some of the changes we discussed this morning. The separate slide-canvas/slide-note bits are part of #11 - which we can clean up once this is merged.

Copy link
Member

@stacyk stacyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just starting to look at this PR, but we have some issues in Safari. I'll keep poking around but wanted to post this in case you had any ideas what is happening here @mirisuzanne.

Screenshot 2024-01-03 at 10 36 48 PM

@stacyk
Copy link
Member

stacyk commented Jan 4, 2024

@mirisuzanne Maybe we can use Auto-fill instead?

autofill

@jamesnw
Copy link
Contributor

jamesnw commented Jan 4, 2024

I like this! I needed to make some minor adjustments to get the control panel working- you can see those changes in 5958c3a

Notably-

  • I needed to set this.controlPanel to the slotted element, falling back to the shadow dom
  • I changed the slideCount from this.childElementCount to this.querySelectorAll(':scope > :not([slot])').length

I also added an example, which is fairly barebones at this point. We probably also want to document this in the README?

@mirisuzanne
Copy link
Member Author

@stacyk I think auto-fill works ok for this. That seems to be a known Safari bug with auto-fit and containers (If you remove the container property on slide-deck, it works fine):

https://bugs.webkit.org/show_bug.cgi?id=256047

@mirisuzanne mirisuzanne merged commit 23afeca into main Jan 4, 2024
4 checks passed
@mirisuzanne mirisuzanne deleted the controls branch January 4, 2024 17:27
Copy link
Contributor

@jamesnw jamesnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

mirisuzanne added a commit that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The control-panel should be fully replaceable
4 participants