-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control panel styles and parts #10
Conversation
✅ Deploy Preview for slide-deck ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@stacyk this isn't ready for a final review, but I could use your feedback on it before going further. |
Discussion this morning:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just starting to look at this PR, but we have some issues in Safari. I'll keep poking around but wanted to post this in case you had any ideas what is happening here @mirisuzanne.
@mirisuzanne Maybe we can use Auto-fill instead? |
I like this! I needed to make some minor adjustments to get the control panel working- you can see those changes in 5958c3a Notably-
I also added an example, which is fairly barebones at this point. We probably also want to document this in the README? |
@stacyk I think auto-fill works ok for this. That seems to be a known Safari bug with auto-fit and containers (If you remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Related Issue(s)
Reminder to add related issue(s), if available.
I provided some basic styles for the control panel, but they could be improved. I'm also not sure if we want to make the entire panel replaceable, or if it's enough to replace the controls inside the panel. I suppose the advantage of replaceing the entire panel is that it could be more easily styled by the page.