Skip to content

Commit

Permalink
Merge pull request #35 from oddbird/updates
Browse files Browse the repository at this point in the history
Update python, node, remove headless images
  • Loading branch information
jgerigmeyer authored Nov 18, 2024
2 parents 87d6d4a + 7767706 commit 394bfeb
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 19 deletions.
13 changes: 3 additions & 10 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,14 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
suffix: ['', '-headless']
python: ['3.12', '3.11', '3.10', '3.9']
node: ['20', '18', '16']
python: ['3.13', '3.12', '3.11']
node: ['22', '20']
steps:
- uses: actions/checkout@v4
- name: Configure tag & caching
run: |
# Set tag
TAG="py${{ matrix.python }}-node${{ matrix.node }}${{ matrix.suffix }}"
TAG="py${{ matrix.python }}-node${{ matrix.node }}"
# Append a PR identifier if necessary
PR="${{ github.event.pull_request.number }}"
if [ ! -z "$PR" ]; then TAG="$TAG-pr$PR"; fi
Expand All @@ -49,12 +48,6 @@ jobs:
CACHEFROM="type=gha"
fi
echo "CACHEFROM=$CACHEFROM" >> $GITHUB_ENV
- name: Prepare Dockerfile
if: matrix.suffix == '-headless'
run: |
mv Dockerfile original.txt
cat original.txt headless.txt > Dockerfile
- name: Prepare image metadata
id: meta
uses: docker/metadata-action@v5
Expand Down
4 changes: 1 addition & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,10 @@ FROM python:${PYTHON_VERSION}
# Node and npm
COPY --from=node_base /usr/local/lib/node_modules /usr/local/lib/node_modules
COPY --from=node_base /usr/local/bin/node /usr/local/bin/node
COPY --from=node_base /opt/yarn-* /opt/yarn
RUN ln -s /usr/local/lib/node_modules/corepack/dist/corepack.js /usr/local/bin/corepack
RUN ln -s /usr/local/lib/node_modules/npm/bin/npm-cli.js /usr/local/bin/npm
RUN ln -s /usr/local/lib/node_modules/npm/bin/npx-cli.js /usr/local/bin/npx
RUN ln -s /opt/yarn/bin/yarn /usr/local/bin/yarn
RUN ln -s /opt/yarn/bin/yarnpkg /usr/local/bin/yarnpkg
RUN corepack enable
RUN node --version && npm --version && yarn --version

# System setup:
Expand Down
6 changes: 0 additions & 6 deletions headless.txt

This file was deleted.

0 comments on commit 394bfeb

Please sign in to comment.