Adjust maintainer contact lint #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shonfeder
force-pushed
the
infra/152/tweak-email-lint
branch
2 times, most recently
from
de35a67 to
5e2fcaf
Compare
punchagan
approved these changes
Nov 25, 2024
shonfeder
force-pushed
the
infra/152/tweak-email-lint
branch
2 times, most recently
from
170bd89 to
b0e4248
Compare
Closes ocaml/infrastructure#152 by addressing the subsequenst requests for tweaked behavior.
For compat in tests between linux and BSD based.
shonfeder
force-pushed
the
infra/152/tweak-email-lint
branch
from
b0e4248 to
ec9e8ae
Compare
|
Thanks for the review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ocaml/infrastructure#152 by addressing
the subsequenst requests for tweaked behavior.
With this change in place, the lint will only fail if there is no email address
at all in the
maintainerfield AND no bug-tracker. We already issue a warningwhen no bug-tracker is present, and since we currently make no distinction
between errors and warnings in our CI results, this check is made somewhat
redundant. However, once #328 is
introduced, the distinction here will make a difference.