Test OCaml for Windows #32
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterDA
changed the title
kit-ty-kate
suggested changes
Jan 14, 2022
server/backend/check.ml
Outdated
Comment on lines
168
to
182
| let with_lower_bound_linux pkg = {| | ||
| if [ $res = 0 ]; then | ||
| opam remove -y "|}^pkg^{|" | ||
| env OPAMCRITERIA="+removed,+count[version-lag,solution]" opam install -vy "|}^pkg^{|" | ||
| res=$? | ||
| fi | ||
| |} | ||
|
|
||
| let with_lower_bound_windows pkg = {| | ||
| if [ $res = 0 ]; then | ||
| ocaml-env exec --64 -- opam remove -y "|}^pkg^{|" | ||
| ocaml-env exec --64 -- env OPAMCRITERIA="+removed,+count[version-lag,solution]" opam install -vy "|}^pkg^{|" | ||
| res=$? | ||
| fi | ||
| |} |
There was a problem hiding this comment.
instead of duplicating every functions I think we should aim at factorising things. For example:
Suggested change
| let with_lower_bound_linux pkg = {| | |
| if [ $res = 0 ]; then | |
| opam remove -y "|}^pkg^{|" | |
| env OPAMCRITERIA="+removed,+count[version-lag,solution]" opam install -vy "|}^pkg^{|" | |
| res=$? | |
| fi | |
| |} | |
| let with_lower_bound_windows pkg = {| | |
| if [ $res = 0 ]; then | |
| ocaml-env exec --64 -- opam remove -y "|}^pkg^{|" | |
| ocaml-env exec --64 -- env OPAMCRITERIA="+removed,+count[version-lag,solution]" opam install -vy "|}^pkg^{|" | |
| res=$? | |
| fi | |
| |} | |
| let with_lower_bound ~windows pkg = | |
| let opam = if windows then "ocaml-env exec --64 -- opam" else "opam" in | |
| {| | |
| if [ $res = 0 ]; then | |
| |}^opam^{| remove -y "|}^pkg^{|" | |
| |}^opam^{| install --criteria="+removed,+count[version-lag,solution]" -vy "|}^pkg^{|" | |
| res=$? | |
| fi | |
| |} |
There was a problem hiding this comment.
That's sensible for these small functions.
There was a problem hiding this comment.
Is it not possible for the main function?
MisterDA
force-pushed
the
windows
branch
2 times, most recently
from
1ac71dd
to
cae5073
Compare
7 tasks
Using Obuilder Docker on Windows backend and ocaml/opam Windows images, currently with opam-dev 2.0 and fdopen/opam-repository-mingw. Server configuration: ```yaml default-repository: fdopen/opam-repository-mingw#opam2 list-command: ocaml-env exec --64 -- opam list --available --installable --short --all-versions platform: os: windows arch: x86_64 distribution: windows-mingw image: ocaml/opam:windows-mingw@sha256:6da6cc25ee75b314d3ef12dfe178f6060940e3c43202541d956f88c8c36b2ab3 ```
MisterDA
force-pushed
the
windows
branch
2 times, most recently
from
85053c5
to
fca0ced
Compare
MisterDA
force-pushed
the
windows
branch
3 times, most recently
from
bdc25ec
to
4f4e9e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Obuilder Docker on Windows backend and ocaml/opam Windows
images, currently with opam 2.0.8 and fdopen/opam-repository-mingw.
Server configuration: