Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert analysis output location removal #677

Merged
merged 5 commits into from
Aug 16, 2024

Conversation

cortadocodes
Copy link
Member

@cortadocodes cortadocodes commented Aug 16, 2024

Contents (#677)

Fixes

  • Pass output arguments into Analysis and use them

Reversions

  • Revert "REF: Stop storing output_location in Analysis"

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.59%. Comparing base (9092646) to head (a382094).
Report is 51 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #677      +/-   ##
==========================================
+ Coverage   94.50%   94.59%   +0.09%     
==========================================
  Files          83       83              
  Lines        3547     3591      +44     
==========================================
+ Hits         3352     3397      +45     
+ Misses        195      194       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cortadocodes cortadocodes self-assigned this Aug 16, 2024
@cortadocodes cortadocodes merged commit f1bce70 into main Aug 16, 2024
5 checks passed
@cortadocodes cortadocodes deleted the revert-analysis-output-location-removal branch August 16, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants