Skip to content

Commit

Permalink
FIX: Fix conflation of None and False in Analysis.finalise
Browse files Browse the repository at this point in the history
  • Loading branch information
cortadocodes committed Aug 16, 2024
1 parent d6a17bc commit a382094
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion octue/resources/analysis.py
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,8 @@ def finalise(self, upload_output_datasets_to=None, use_signed_urls=None):
if self.output_location and not upload_output_datasets_to:
upload_output_datasets_to = storage.path.join(self.output_location, coolname.generate_slug())

use_signed_urls = use_signed_urls or self.use_signed_urls_for_output_datasets
if use_signed_urls is None:
use_signed_urls = self.use_signed_urls_for_output_datasets

# If there isn't both an output manifest and upload location, nothing is uploaded.
if not (upload_output_datasets_to and hasattr(self, "output_manifest")):
Expand Down

0 comments on commit a382094

Please sign in to comment.