Fix Backup and Restore being unable to read file. #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added additional proguard rules to allow the backup and restore functionality to access files and start a foreground service. Fixes octoshrimpy#70, octoshrimpy#148.
This was referenced Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional proguard rules to allow the backup and restore functionality to access files and start a foreground service. The reason it worked in QKSMS is because their backup and restore code was different and used a file path as a string and not a URI. To use the URI, the app needed Dagger and RxJava, which was blocked by proguard. I also added a rule that keeps the package name, to allow the foreground service to start up.
Closes #70,
Closes #148.