Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(test): add checkJS step to test.yml workflow #36

Merged
merged 2 commits into from
May 11, 2021

Conversation

oscard0m
Copy link
Member

@oscard0m oscard0m commented May 11, 2021

📝 Summary

  • Add checkJS step to test.yml workflow
  • Octoherd scripts will be scaffolded with this check in their test.yml file

⚠️ I guess this is blocked by: octoherd/script-setup-renovate#3 (see errors in https://github.com/octoherd/create-octoherd-script/runs/2557871514?check_suite_focus=true)

  • Installed @types/node as devDependency

⛱ Motivation and Context

To improve CI in Octoherd's scripts ecosystem to validate and assure JS code merged compiles
Fix #16

@oscard0m oscard0m requested a review from gr2m May 11, 2021 16:36
@gr2m
Copy link
Member

gr2m commented May 11, 2021

⚠️ I guess this is blocked by: octoherd/script-setup-renovate#3 (see errors in https://github.com/octoherd/create-octoherd-script/runs/2557871514?check_suite_focus=true)

I think these are two different things. The code in this repository is node only, it's not an @octoherd script. In order to make the TS check pass, we can add the missing types as dev dependencies to this repository

to make npx -p typescript tsc --allowJs --noEmit --lib es2020 *.js pass
@oscard0m
Copy link
Member Author

⚠️ I guess this is blocked by: octoherd/script-setup-renovate#3 (see errors in https://github.com/octoherd/create-octoherd-script/runs/2557871514?check_suite_focus=true)

I think these are two different things. The code in this repository is node only, it's not an @octoherd script. In order to make the TS check pass, we can add the missing types as dev dependencies to this repository

You are right. Types added 🔁 👓

Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@gr2m gr2m merged commit ebb2611 into main May 11, 2021
@gr2m gr2m deleted the add-checkJS-step-to-test.yml branch May 11, 2021 18:38
@github-actions
Copy link

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we run tsc --checkJs as a checkRun on CI?
2 participants