-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update query #2
base: main
Are you sure you want to change the base?
Conversation
@@ -79,15 +79,16 @@ def get_account_number(token: str) -> str: | |||
|
|||
|
|||
GET_HH_BODY = """ | |||
query halfHourlyReadings($accountNumber: String!, $fromDatetime: DateTime, $toDatetime: DateTime) { | |||
query halfHourlyReadings($accountNumber: String!, $fromDatetime: DateTime, $toDatetime: DateTime, $productCode: String!) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'd also need to update the place where this is used I think - down on line 117
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FraserTooth did you mean around here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b51351c
to
6fdcb42
Compare
) -> List[HHReading]: | ||
|
||
variables = { | ||
"accountNumber": account_number, | ||
"fromDatetime": start_at.isoformat(), | ||
"productCode": product_code, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bit - you found it tho 👍
Summary
This PR updates example of
halfHourlyReadings
query, which was updated on the prod.costEstimate
added as return valueproductCode
is required as one of the query variables🤚 Need help
I updated body in
octopus.py
, but I assume I also need to maintain other place as well such as something like settingdef get_product_code(???) -> str:
🙇