The record got field names from the DNSKEY record by accident, fix this

[baest]

Basically changing from
https://www.rfc-editor.org/rfc/rfc4034.html#section-2.1 to https://www.rfc-editor.org/rfc/rfc4034.html#section-5.1

So:
flags -> key_tag
protocol -> algorithm
algorithm -> digest_type
public_key -> digest

[ross]

Thanks for the find & even more for the PR with the fixes. Comments inline. Once they're sorted we can move this forward.

[ross]

Added a DEPRECATION warning when the old fields are used so that we can eventually remove the backwards compat. I think this is gtg.

Thanks!

[ross]

Ah. Once the integration tests run it caught an issue where the old property names are being accessed. That should be easy enough to fix.

https://github.com/octodns/octodns/actions/runs/6285771507/job/17068502376?pr=1065

[ross]

So I was going to add back the "legacy" properties, but realized that algorithm is in both the old and new and that wouldn't work. Good news is that octodns-powerdns has never been released with DS support so we at least have options. I think we'll have to go about this a bit differently and reorder things a bit.

1. Merge this change
2. [ ] Once a release of octoDNS core has been made with DS fixes update octodns-powerdns to require >= that new release
3. [ ] Merge Add support for the DS record (with updated field names) octodns-powerdns#50 to update octodns-powerdns to use the new values
4. [ ] Cut a release of octodns-powerdns

Edit: reordered 2 & 3 as it looks like we'll need to cut a new release of core for octodns/octodns-powerdns#50 to require before it'll pass CI

[ross]

Scratch the last comment about process. After looking at the version checking patch I realized that the cleanest path forward would be to have octodns-powerdns just handle both ways transparently. Since there hasn't been a release with DS support yet that should be enough, octodns/octodns-powerdns#51 does this.