Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit connection to insecure ssl server #45

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Conversation

shubazalam
Copy link
Contributor

@shubazalam shubazalam commented Aug 25, 2023

Hi there,

Add an option to allow SSL connexion with a self-signed certificate.

(Please be indulgent with my first PR.)

Copy link
Contributor

@ross ross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and makes sense to support the option. Couple of minor suggestions inline. Once those are sorted this should be good to 🚢

octodns_powerdns/__init__.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
shubazalam and others added 2 commits August 25, 2023 23:57
Co-authored-by: Ross McFarland <[email protected]>
@shubazalam
Copy link
Contributor Author

Thanks for your review.

@ross ross merged commit 58b2a25 into octodns:main Aug 25, 2023
5 checks passed
@ross
Copy link
Contributor

ross commented Aug 25, 2023

Thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants