Initial/wip changelists support #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ross
commented
Mar 1, 2024
| @@ -287,7 +321,10 @@ def _apply_Delete(self, change): | |||
| name = self._set_full_name(change.existing.name, zone) | |||
| record_type = change.existing._type | |||
|
|
|||
| self._dns_client.record_delete(zone, name, record_type) | |||
| if self.use_changelist: | |||
| self._dns_client.changelist_record_delete(zone, content) | |||
There was a problem hiding this comment.
coho:octodns-edgedns ross$ ./script/lint
octodns_edgedns/__init__.py:325:61: undefined name 'content'| @@ -70,18 +70,36 @@ def record_create(self, zone, name, record_type, content): | |||
|
|
|||
| return result | |||
|
|
|||
| def changelist_record_create(self, zone, content): | |||
There was a problem hiding this comment.
I think it'd be cleaner to have a single record_create method and then do an if self.use_changelist: in that method to decide how to go about things. Same goes for all the other methods here. That'll avoid spreading the logic of use_changelist all throughout the code and instead push it down to a single point for each action.
| @@ -253,10 +277,16 @@ def _apply(self, plan): | |||
| self._dns_client.zone_changelist_create(zone_name) | |||
| self._dns_client.zone_changelist_submit(zone_name) | |||
|
|
|||
| if self.use_changelist: | |||
| self._dns_client.zone_changelist_create(zone_name, overwrite=True) | |||
There was a problem hiding this comment.
Doesn't this always recreate the zone or is it more of a create if not exists sort of thing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[TODO]
/cc @TheDJVG as the author of the patch
/cc Fixes #38