Return c_t, s_k, s_p, and s_t to hlig from dlig #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change restores the categorization from @georgd's [specimen]. Related to <octaviopardo#20>. See also <octaviopardo#4 (comment)>. To do: - The .glyphs files should be either updated or removed. - The build script for variable fonts should be updated. - Generated files changed to use names based on "EBGaramond12". They should probably go back to using "EBGaramond", instead. - Medium, SemiBold, and ExtraBold weights are missing and should be restored. [specimen]: https://github.com/georgd/EB-Garamond/blob/82c892d3b1ecf6fe52554c5133af9127974b9be8/specimen/Specimen.pdf
AndrewKvalheim
added a commit
to AndrewKvalheim/EBGaramond12
that referenced
this pull request
Dec 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR returns the ligatures
c_t,s_k,s_p, ands_ttohligfromdlig, restoring the categorization from @georgd's specimen.Related to #20 and #4 (comment).
I expect some changes will be needed before this can be merged:
glyphs2ufoto generate.ufoand.designspacefiles, edited thefeatures.feafiles, and generated OTF and TTF formats usingfontmake. If you want to keep.glyphsas the canonical format, presumably I should useufo2glyphsto update the.glyphsfiles. However, I think it would make more sense to keep UFO in this repository, rather than a proprietary format.EBGaramond12rather thanEBGaramond, and theMedium,SemiBold, andExtraBoldweights are missing. Hopefully this is just a matter of passing the right options tofontmake.