Remove config files generation from Makefiles #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the config files generation compatible with a dune rule.
This will allow to generate this file from a different build system.
ocsigen_config_static.ml is generated from a dune rule and automatically registered into the library. ocsigenserver.conf.sample and local/etc/ocsigenserver.conf are generated and promoted into the worktree with dune rules. Dependencies are computed from Dune. For example, changing the generator script or changing options.ml with ./configure will trigger a rebuild.
Julow
force-pushed
the
makefile-remve-config-gen
branch
from
df5642c to
562b8a3
Compare
|
I rebased this PR, which is ready for review. I needed this work to be able to run |
Only src/server/Makefile remains.
Julow
force-pushed
the
makefile-remve-config-gen
branch
from
562b8a3 to
c6c3dcf
Compare
Julow
force-pushed
the
makefile-remve-config-gen
branch
from
c6c3dcf to
55ffc15
Compare
Julow
force-pushed
the
makefile-remve-config-gen
branch
from
c0f87c1 to
b4dece9
Compare
smorimoto
approved these changes
Apr 23, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generates the config files and
ocsigen_config_static.mlusing an OCaml script called from Dune rules. This allows to remove several Makefiles and allows building more of the project using Dune.src/files/ocsigenserver.conf/options.mlis generated from theconfigurescript but is also included in the source tree with default values that allow to build a bigger part of the project without running theconfigurescript.