Some clean up in CONTRIBUTING.md and fix broken links & redirects #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 1, 2024 09:55
Also removed [style.css] which does not seem to be used anywhere.
Not sure, but it seems like this test is a noop if we assume that neither Travis nor Appveyor is used.
Docs: fix broken links and redirects
arvidj
force-pushed
the
arvid@clean-up-contributing
branch
from
b46ba85 to
59006a9
Compare
|
Fixes #839 |
MisterDA
suggested changes
Nov 5, 2024
Comment on lines
-14
to
-26
| (* Check if this is running inside Travis or AppVeyor. *) | ||
| let in_travis = | ||
| try ignore (Sys.getenv "TRAVIS_COMMIT"); true | ||
| with Not_found -> false | ||
| in | ||
|
|
||
| let in_appveyor = | ||
| try ignore (Sys.getenv "APPVEYOR_REPO_COMMIT"); true | ||
| with Not_found -> false | ||
| in | ||
|
|
||
| if not (in_travis || in_appveyor) then Lwt.return_true | ||
| else Lwt.return Lwt_config.libev_default); |
There was a problem hiding this comment.
Instead of deleting this, you could check whether the CI env var is true or True, or check whether GITHUB_ACTIONS is true.
There was a problem hiding this comment.
I wasn't quite sure of the meaning of this test. Since in_travis and in_appveyor would always be false, it's basically a noop. I can do what you propose, and then the meaning of the test would be "if we're in github actions, then check that Lwt_config.libev_default is true". Is that what we want the test to check (if so, why do we want to test that?)?
There was a problem hiding this comment.
It's probably left-over from special-casing for different CIs and I think we can remove it.
- drop reddit info (deprecated) - add reference to lwt_domain
|
Thanks a lot for the long overdue fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: