Fix js parsing #1449
Merged
Fix js parsing #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
added a commit
to grain-lang/libbinaryen
that referenced
this pull request
Apr 19, 2023
|
Awesome!!! I just ran this on my mac and the numbers were roughly what I expected in 5.0 - I pushed to grain-lang/libbinaryen#78 to run it in our CI matrix too |
Fix memory usage Fix comment token disapearing during recovery
|
@phated, your CI seems to be happy. I'll merge this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #1444.
Compared to master:
Time and memory are closer to what they were with jsoo 5.0 but are still a little higher
@phated, do you want to give this a try ?