Fixed ocp-e2e role by replacing core make module with community.general make module #87
Conversation
ppc64le-cloud-bot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: SurajGudaji, varad-ahirwadkar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Can we not use community.general.make? ref: https://docs.ansible.com/ansible/latest/collections/community/general/make_module.html
Please check #42 |
…al make module Signed-off-by: SurajGudaji <[email protected]>
Yes we can, I have added 'community.general.make' module. |
SurajGudaji
changed the title
| - Install community.general collection | ||
| ``` | ||
| ansible-galaxy collection install community.general | ||
| ``` |
There was a problem hiding this comment.
This is already defined in the main README. I will merge this anyway.
| @@ -69,7 +69,7 @@ | |||
| ansible_distribution == 'Ubuntu' | |||
|
|
|||
| - name: Run make target | |||
| make: | |||
| community.general.make: | |||
There was a problem hiding this comment.
@varad-ahirwadkar can you confirm this change is needed?
Last time when you encountered this just collection install was enough?
Fixed ocp-e2e role by replacing core make module with community.general make module.