Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPTAA-D #1167

Merged
merged 2 commits into from
Aug 29, 2024
Merged

OPTAA-D #1167

merged 2 commits into from
Aug 29, 2024

Conversation

kpolitano
Copy link

2x OPTAA Cal files for Fall24

@kpolitano kpolitano requested review from cwingard and desiderr August 23, 2024 16:34
desiderr
desiderr approved these changes Aug 23, 2024
View reviewed changes
Copy link

@desiderr desiderr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked by eye, first and last 3 values in vectors, and corners in 2D arrays. Looks good.

@kpolitano
OPTAA-D
b23ec43 
2x OPTAA Cal files for Fall24
@kpolitano kpolitano requested a review from desiderr August 27, 2024 17:00
@kpolitano
Copy link
Author

Added OPTAA-D SNs 127 and 136 to previous pull request

cwingard
cwingard approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@cwingard cwingard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled from Alfresco and cross-compared. Look good to me.

desiderr
desiderr approved these changes Aug 29, 2024
View reviewed changes
Copy link

@desiderr desiderr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the calibration files for acs-149 and acs-174, I approve this pull request. I had already approved the addition of the calibration files for acs-127 and acs-136.

@desiderr desiderr merged commit f79a585 into oceanobservatories:master Aug 29, 2024
1 check passed
@kpolitano kpolitano deleted the OPTAA-D branch September 3, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desiderr desiderr desiderr approved these changes

@cwingard cwingard cwingard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpolitano @cwingard @desiderr