Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datatransfer): invalid batchSize when importing external csv file #4173

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

LuckyPickleZZ
Copy link
Collaborator

What type of PR is this?

type-bug

What this PR does / why we need it:

When importing external csv file, odc would not set batchSize for obloader.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@LuckyPickleZZ LuckyPickleZZ added this to the ODC 4.3.3 milestone Jan 16, 2025
@LuckyPickleZZ LuckyPickleZZ self-assigned this Jan 16, 2025
LioRoger
LioRoger previously approved these changes Jan 16, 2025
Copy link
Collaborator

@LioRoger LioRoger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
but if config is null, given a proper default value is a better choice

Copy link
Collaborator

@LioRoger LioRoger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LioRoger LioRoger merged commit dbdabc2 into dev/4.3.x Jan 16, 2025
7 checks passed
@LioRoger LioRoger deleted the wenmu_433_fix_load_batch_size_invalid branch January 16, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Developed
Development

Successfully merging this pull request may close these issues.

2 participants