fix(function):The function does not display properly if the return value type is year #4093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LioRoger
reviewed
Dec 24, 2024
server/odc-core/src/main/java/com/oceanbase/odc/core/sql/util/JdbcDataTypeUtil.java
Outdated
Show resolved
Hide resolved
zijiacj
changed the title
zijiacj
force-pushed
the
fix/function_return_incorrect_where_return_type_is_year
branch
from
ccb3ace to
d946ff9
Compare
LioRoger
reviewed
Dec 30, 2024
server/odc-core/src/main/java/com/oceanbase/odc/core/sql/util/JdbcDataTypeUtil.java
Outdated
Show resolved
Hide resolved
...odc-service/src/main/java/com/oceanbase/odc/service/db/util/OBMysqlCallFunctionCallBack.java
Outdated
Show resolved
Hide resolved
...odc-service/src/main/java/com/oceanbase/odc/service/db/util/OBMysqlCallFunctionCallBack.java
Outdated
Show resolved
Hide resolved
PeachThinking
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-bug
What this PR does / why we need it:
create function
fun_year(p1year) returns year beginreturn p1;
end;
In ob mysql tenant. The input and return parameters of the above function are both of the year type. The function is executed in black screen. the input and output are both 2024. However, the value obtained by jdbc using getString is 2024-01-01, which is inconsistent with black screen.
Current the jdbc of
obspecifies that theyeartype corresponds toShortin java, so changed fromgetStringtogetShortFor getting function execution results from database which dialect_type is
mysql, useJdbcRowMapperto handle the type conversionWhich issue(s) this PR fixes:
Fixes #3942
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: