feat(datasource): supports creating and testing OSS data sources #3879
Conversation
guowl3
requested review from
yhilmare,
yizhouxw and
MarkPotato777
as code owners
| @@ -97,7 +99,9 @@ public ConnectionTestResult test(@NotNull @Valid TestConnectionReq req) { | |||
| if (req.getAccountType() == ConnectionAccountType.SYS_READ) { | |||
| connectionConfig.setDefaultSchema(null); | |||
| } | |||
| return test(connectionConfig); | |||
| return connectionConfig.getDialectType() == DialectType.FILE_SYSTEM | |||
There was a problem hiding this comment.
this switch is not easy to extend, if a new type involved, it may missed to change this code.
can we designed a new way to force the user feel this method?
| */ | ||
|
|
||
| @Component | ||
| public class FileSystemConnectionTesting { |
There was a problem hiding this comment.
Testing means in do test process. it's a verb, use noun is more suitable
| @Component | ||
| public class FileSystemConnectionTesting { | ||
|
|
||
| private static final String COS_ENDPOINT_REGEX = "cos\\.(\\w+-\\w+)\\.myqcloud\\.com"; |
There was a problem hiding this comment.
as this regex will be compiled to Pattern. declare pattern, please confirm Pattern is thread safe
| return ConnectionTestResult.success(config.getType()); | ||
| } catch (CloudException e) { | ||
| if (e.getCause() instanceof OSSException) { | ||
| OSSException cause = (OSSException) e.getCause(); |
There was a problem hiding this comment.
aware of npe and class cast exception
| public PutObjectResult putObject(String bucketName, String key, InputStream in, ObjectMetadata metadata) | ||
| throws CloudException { | ||
| return callAmazonMethod("Put object", () -> { | ||
| com.amazonaws.services.s3.model.ObjectMetadata objectMetadata = toS3(metadata); |
There was a problem hiding this comment.
is this package prefix needed?
| private String getEndPointRegex(ConnectType type) { | ||
| switch (type) { | ||
| case COS: | ||
| return COS_ENDPOINT_REGEX; |
There was a problem hiding this comment.
as you have so many switch case around your code, reconstruct may needed.
let enum's member hold this fields. or put what programmer must implement to enums class to aware if you want to add some type ,you should do like this way
# Conflicts: # pom.xml # server/odc-service/src/main/java/com/oceanbase/odc/service/dlm/DataSourceInfoMapper.java
What type of PR is this?
type-feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: