Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vote for fe-lint-config repo #27

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hetao92
Copy link

@hetao92 hetao92 commented Jan 14, 2025

Summary

We want to create a repo with a unified coding standards for all oceanbase front-end projects (including open source projects)

Solution Description

@CLAassistant
Copy link

CLAassistant commented Jan 14, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@Teingi Teingi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whhe
Copy link
Member

whhe commented Jan 14, 2025

I have nothing to do with the vote, just wondering is it a repository for specification documents, or it's a template repository?

@hetao92
Copy link
Author

hetao92 commented Jan 14, 2025

I have nothing to do with the vote, just wondering is it a repository for specification documents, or it's a template repository?

@whhe This is a plugin repository for standardizing the front-end code style. Users can use this plugin in project code. It has built-in default rules and supports custom modification of default configurations.

@whhe
Copy link
Member

whhe commented Jan 14, 2025

I have nothing to do with the vote, just wondering is it a repository for specification documents, or it's a template repository?

@whhe This is a plugin repository for standardizing the front-end code style. Users can use this plugin in project code. It has built-in default rules and supports custom modification of default configurations.

So it sounds like to be a template repository like https://github.com/apache/template-site?

Copy link
Member

@whhe whhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After talking with @hetao92, I realized that this repository will publish a base package for other front-end projects, so it has nothing to do with the template repository. I have no further questions and +1 for the vote.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants