-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Syntax Documentation to vscode #1313
Conversation
Could you add a change log entry and run the code format? |
Thanks, done in the newest commits. |
Thanks @PizieDust, looks good :-) |
…nto add_syntax_doc_gui
The lint-fmt check is still failing. I think you need to format again. |
@smorimoto I am not familiar with the interactions between the plugin and the server: what happens if a version of the plugin with this new configuration option is released but the server does not understand it ? (We still have to merge the Merlin PR and release it before merging the lsp-server one.) Will the option be shown even if it is not functional yet ? |
It's shown even if it's not functional yet, but it doesn't cause the server to crash, so nothing should happen with this now. |
closes #1312
This PR adds a new GUI option for
Syntax Documentation
to this vscode extension.This PR depends on ocaml/ocaml-lsp#1218 which is unmerged.
We can activate this feature using
OCAMLLSP_ENABLE_SYNTAX_DOCUMENTATION
inextraEnv
or viaocaml.server
cc @voodoos @pitag-ha