Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] merlin and merlin-lib v4.15-414/501 #26002

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

voodoos
Copy link
Contributor

@voodoos voodoos commented May 31, 2024

CHANGES:

Fri May 31 14:02:42 CEST 2024

  + merlin binary
    - destruct: Removal of residual patterns (ocaml/merlin#1737, fixes ocaml/merlin#1560)
    - Do not erase fields' names when destructing punned record fields (ocaml/merlin#1734,
      fixes ocaml/merlin#1661)
    - Ignore SIGPIPE in the Merlin server process (ocaml/merlin#1746)
    - Fix lexing of quoted strings in comments (ocaml/merlin#1754, fixes ocaml/merlin#1753)
    - Improve cursor position detection in longidents (ocaml/merlin#1756)
@mseri
Copy link
Member

mseri commented Jun 1, 2024

Seems like none of the merlin is installable, e.g.

merlin.4.15-414 is not installed. Install it? [y/n] y
  * No agreement on the version of merlin-lib:
    - merlin = 4.15-414 -> dot-merlin-reader >= 4.9 -> merlin-lib < 4.14-502
    - merlin = 4.15-414 -> merlin-lib = 4.15-414
  * No agreement on the version of ocaml:
    - (invariant) -> ocaml-base-compiler = 4.14.2 -> ocaml = 4.14.2
    - merlin = 4.15-414 -> dot-merlin-reader >= 4.9 -> ocaml >= 5.2
    You can temporarily relax the switch invariant with `--update-invariant'

@voodoos
Copy link
Contributor Author

voodoos commented Jun 3, 2024

With the final release of Merlin for 5.2 I decided to bump the major version number due to the large number of apj changes.
I moved the constraint to be merlin-lib < 5.0, which should hold for some time since we are only going to do maintenance releases for older versions of the compiler.

I am wondering whether we should move to always releasing dot-merlin-reader along with merlin/merlin-lib either if there is no changes at all to simplify the version contraints ?

@mseri I surprised that the CI turned green with one of the two packages released actually being un-installable 😅

@mseri
Copy link
Member

mseri commented Jun 3, 2024

Thanks. Now it looks all right.

@mseri I surprised that the CI turned green with one of the two packages released actually being un-installable 😅

Failing to satisfy the constraints is a "SKIP [Package not available]" warning since there are a massive amount of packages that are uninstallable in certain configurations by design. It is for us to check that it looks all right in the fully unistallable cases, but probably a lint could be added for this

@mseri mseri merged commit 478f3b1 into ocaml:master Jun 3, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants