Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package bip340.0.1.1 #25680

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andunieee
Copy link

@andunieee andunieee commented Apr 16, 2024

bip340.0.1.1

bitcoin schnorr signatures
libsecp256k1 wrapper for OCaml that only exposes a few primitives required for creating and verifying Schnorr signatures.



🐫 Pull-request generated by opam-publish v2.3.0

@samoht
Copy link
Member

samoht commented Apr 17, 2024

@andunieee, it seems that you forgot to add the right dependencies in the opam file. I've tried to add the one corresponding to the build errors I saw, but you might want to have a look and fix this in your package directly so that the next releases go smoothly.

@andunieee andunieee changed the title Package bip340.0.1.0 Package bip340.0.1.1 Apr 22, 2024
@andunieee
Copy link
Author

Sorry, this is my first time publishing a package. I've fixed it an updated the tag to 0.1.1, but kept all in this same PR if that is ok. Next time will be better. Thank you!

@mseri
Copy link
Member

mseri commented Apr 22, 2024

Looks like a system dependency is missing:

# /usr/bin/ld: cannot find -lsecp256k1: No such file or directory

Can you check if a suitable conf- package is already present or create one and depend on it? See e.g. https://github.com/ocaml/opam-repository/blob/master/packages/conf-libpcre/conf-libpcre.1/opam for an example (in the opam-repository wiki here on github you can also find where to look for the package names)

@andunieee
Copy link
Author

OK, give me some more time and I'll try to figure out how to add the dependency.

Should be ok if I look into other Opam packages that also depend on exotic C libraries, right?

@mseri
Copy link
Member

mseri commented Apr 27, 2024

Sure, they are usually called conf- followed by the name of the main system library they install. See also https://github.com/ocaml/opam-repository/wiki/Depexts-os-distribution---os-family-values

@raphael-proust
Copy link
Collaborator

FWI, the package conf-secp256k1 already exists. Considering the error message, I'd guess this is the system library you need to depend on.

@shonfeder
Copy link
Collaborator

Hi @andunieee. Just checking in whether you would still like to land this in the repo, and if so, whether there is any additional support or pointers we can provide that would help!

maintainer: ["[email protected]"]
authors: ["andunië"]
license: "MIT"
tags: ["topics" "bitcoin" "schnorr" "taproot" "bip340"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: topics tag can be removed here.

maintainer: ["[email protected]"]
authors: ["andunië"]
license: "MIT"
tags: ["topics" "bitcoin" "schnorr" "taproot" "bip340"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tags: ["topics" "bitcoin" "schnorr" "taproot" "bip340"]
tags: ["bitcoin" "schnorr" "taproot" "bip340"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants