Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver: Fix monorepo mode #1299

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

jonludlam
Copy link
Member

No description provided.

@jonludlam jonludlam force-pushed the fix-monorepo-stack-overflow branch 2 times, most recently from 10d32a9 to 9372978 Compare February 3, 2025 17:14
Copy link
Collaborator

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs formatting.

@Julow Julow added the no changelog This pull request does not need a changelog entry label Feb 4, 2025
l.requires
in
let libs =
if l.name = "stdlib" then libs else "stdlib"::libs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditionally adding stdlib is the only change ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

@jonludlam jonludlam force-pushed the fix-monorepo-stack-overflow branch from 9372978 to 14bfbe9 Compare February 6, 2025 22:54
@jonludlam jonludlam merged commit b23798d into ocaml:master Feb 7, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog This pull request does not need a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants