fixes anchor appearing bellow search bar #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmileTrotignon
added
the
no changelog
Julow
reviewed
Dec 5, 2023
src/html_support_files/odoc.css
Outdated
| @@ -95,7 +95,10 @@ | |||
|
|
|||
| :root, | |||
| .light:root { | |||
| --main-background: #FFFFFF; | |||
|
|
|||
| scroll-padding-top: 100px; | |||
There was a problem hiding this comment.
Shouldn't this be in em, like the font size and the margin of items ?
There was a problem hiding this comment.
More than a specific unit, shouldn't this be computed from --search-bar-height and --search-padding-top to be sure it is enough? Something like:
Suggested change
| scroll-padding-top: 100px; | |
| scroll-padding-top: calc(var(--search-bar-height) + var(--search-padding-top) + 20px); |
Where 20px can be replaced by a size in em if needed.
EmileTrotignon
force-pushed
the
anchor_scroll
branch
from
bbfa2d6 to
f81202f
Compare
panglesd
approved these changes
Dec 6, 2023
EmileTrotignon
force-pushed
the
anchor_scroll
branch
from
b5a71ff to
96ef7e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used to be that the when following a link to an anchor, the anchor would appear a the top of the view, which was under the new search bar. This adds a margin of a 100px to such jumps.