Use a map to memoize looked-up items in signatures #1049
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpetiot
changed the title
Lookups are cached in each Component.Signature values to help avoid time blowup on large signatures due to the linear lookup.
Julow
requested changes
Jan 15, 2024
| let find_in_sig : | ||
| Signature.t -> string -> (Signature.item -> 'a option) -> 'a option = | ||
| fun sg name f -> | ||
| try find_map f (StringMap.find name sg.lookup_cache) |
There was a problem hiding this comment.
With @gpetiot we found a bug here:
Say a signature contains both a module and a module type named Foo. A first lookup to the module would populate the cache with only the module. A second lookup to signature_in_sig would find something in the cache and never go through the linear lookup to find the module type.
|
We'll close this prototype due to a lack of time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this PR for ocaml-benchmarks. Follow-up of #1039