Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the dune developer preview #2706

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

maiste
Copy link
Contributor

@maiste maiste commented Sep 18, 2024

Hi 👋
This PR introduces an explanation about the Dune Dev Preview we are putting in place to provide early access to Dune Package Management. It's still a draft as we need to finish some business on our side before publishing this and rewrite some part of it. I made it public so we can iterate over it.

@sabine, @cuihtlauac do you think it would be possible to add a header for a limited time to promote this? I can do it, but I want to have your green light on this before investing some time.

@cuihtlauac
Copy link
Collaborator

cuihtlauac commented Sep 19, 2024

Do you mean a banner like the one we had for OCaml 5.0.0? As in PR #709? (Also look at PR #1004)

@maiste
Copy link
Contributor Author

maiste commented Sep 19, 2024

Yes exactly this! 🙏

@cuihtlauac
Copy link
Collaborator

Why not? Dune is part of the OCaml platform. Let's find color and text.

@maiste
Copy link
Contributor Author

maiste commented Sep 20, 2024

Thanks! I'll update the PR with the top bar, following the instruction in the provided PRs.

For the color, I would suggest #B0A687: it's the grey / cream color from the Dune logo 👍

@maiste
Copy link
Contributor Author

maiste commented Sep 20, 2024

Should put the link in url.ml instead of hardcoding it?

package repository called `opam-repository`. It contains around 5000 packages of
the OCaml ecosystem.

However, with time, the OCaml Community has raised concerned about having a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd lead this with positive things about the new workflow instead of negative things about the existing one.

Copy link
Contributor Author

@maiste maiste Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it sound better if I replace the "However, with time, [...] have raised concerned" by "With time, the OCaml Comunity have suggested to have [...]"? This way, the sentence does not contain anything negative.

My point here is just to emphasise that this is a community wanted feature.

@cuihtlauac
Copy link
Collaborator

Here is how it looks like
Screenshot_2024-09-20_13-36-52
Screenshot_20240920-133858

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants