Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use layout opam in .envrc in opam path doc #2597

Closed
wants to merge 1 commit into from

Conversation

smorimoto
Copy link
Member

@smorimoto smorimoto commented Jul 13, 2024

@@ -14,7 +14,7 @@ The `opam env` command is used to set environment variables for a specific opam

Usage:
```bash
$ eval $(opam env)
$ eval "$(opam env)"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -47,15 +47,15 @@ Ensure `direnv` is installed on your system. You can install it using a package

Add the following line to your shell profile (e.g., `~/.bashrc` or `~/.zshrc`):
```bash
$ eval $(direnv hook <shell>)
$ eval "$(direnv hook <shell>)"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smorimoto smorimoto marked this pull request as draft July 15, 2024 09:08
Copy link
Collaborator

@cuihtlauac cuihtlauac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @smorimoto, thanks for adding support for opam in direnv; this is great. I love that tool. Could you add a note on direnv version and use case? It will take time until your direnv patch lands in distros. In the interim, we need to support both syntaxes.

Also, I've merged the changes unrelated to direnv in a separate PR: #2602. You'll have to rebase

@sabine
Copy link
Collaborator

sabine commented Aug 5, 2024

Is this ready to merge?

@smorimoto
Copy link
Member Author

Not yet! We have to wait for the next direnv release 🥲

@tmattio
Copy link
Collaborator

tmattio commented Oct 1, 2024

As I understand, this will only be compatible with the last version of direnv. Even when it is released, we can't assume the user will have this version, so I think it's a bit too early to recommend users to use this.

@tmattio tmattio closed this Oct 1, 2024
@smorimoto
Copy link
Member Author

@smorimoto
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants