-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use layout opam
in .envrc
in opam path doc
#2597
Conversation
smorimoto
commented
Jul 13, 2024
•
edited
Loading
edited
- feat: add opam support direnv/direnv#1298
Signed-off-by: Sora Morimoto <[email protected]>
@@ -14,7 +14,7 @@ The `opam env` command is used to set environment variables for a specific opam | |||
|
|||
Usage: | |||
```bash | |||
$ eval $(opam env) | |||
$ eval "$(opam env)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -47,15 +47,15 @@ Ensure `direnv` is installed on your system. You can install it using a package | |||
|
|||
Add the following line to your shell profile (e.g., `~/.bashrc` or `~/.zshrc`): | |||
```bash | |||
$ eval $(direnv hook <shell>) | |||
$ eval "$(direnv hook <shell>)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @smorimoto, thanks for adding support for opam in direnv; this is great. I love that tool. Could you add a note on direnv version and use case? It will take time until your direnv patch lands in distros. In the interim, we need to support both syntaxes.
Also, I've merged the changes unrelated to direnv in a separate PR: #2602. You'll have to rebase
Is this ready to merge? |
Not yet! We have to wait for the next direnv release 🥲 |
As I understand, this will only be compatible with the last version of direnv. Even when it is released, we can't assume the user will have this version, so I think it's a bit too early to recommend users to use this. |