Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DocumentUri converter directly in Merlin Call Compatible params #1429

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

voodoos
Copy link
Collaborator

@voodoos voodoos commented Dec 20, 2024

It makes the intent clearer than relying on "unwrapping" a TextDocumentIdentifier.t (which is an object with a unique uri : DocumentUri.t field).

Ideally, we could change the spec of the request to better fit into the protocol to have a textDocument : TextDocumentIdentifier.t instead of a uri : DocumentUri.t. The same information is conveyed, but the former version is the one used across the protocol and most other custom queries.

We could transition by recognizing both fields until the clients are all updated ?

This is a follow-up to #1428.

cc @awilliambauer

@coveralls
Copy link

coveralls commented Dec 20, 2024

Pull Request Test Coverage Report for Build 4671

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.004%) to 22.171%

Files with Coverage Reduction New Missed Lines %
ocaml-lsp-server/src/import.ml 1 34.69%
Totals Coverage Status
Change from base Build 4668: -0.004%
Covered Lines: 5650
Relevant Lines: 25484

💛 - Coveralls

This makes the intent clearer.
@voodoos voodoos force-pushed the refactor-req-merlin-compatible branch from 6f31e28 to beaf5de Compare December 20, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants