Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow esy as merlin-command to call merlin via esy exec-command #996

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

actionshrimp
Copy link
Contributor

The same idea as the 'opam merlin command, however esy exec-command is a lot quicker so we can call it directly rather than grabbing it's config and setting the PATH.

This means we have to allow merlin-command to return more than just the binary name as we need the additional base args - hopefully I've updated all the call sites that depend on that but would appreciate a second pair of eyes!

@andreypopp
Copy link
Member

Don't use emacs so don't really know if this is the correct way to implement this but the idea is sound — I used the same in vim before I switched to merlin-lsp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants