Fix letops tuples handling (fixes #1683 and ocaml/ocaml-lsp#1182) #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voodoos
added a commit
to voodoos/merlin
that referenced
this pull request
Sep 26, 2023
…1182) (ocaml#1684) from voodoos/letop-tuples-issue-1683
voodoos
added a commit
that referenced
this pull request
Sep 26, 2023
…#1684) from voodoos/letop-tuples-issue-1683
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Sep 26, 2023
CHANGES:
Tue Sep 26 17:45:42 CEST 2023
+ merlin binary
- Fix issue with let operators and tuples (ocaml/merlin#1684, fixes ocaml/merlin#1683, fixes
ocaml/ocaml-lsp#1182)
- Fix an issue causing Merlin locate queries to hang (ocaml/merlin#1686,
fixes ocaml/ocaml-lsp#1192)
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Sep 26, 2023
CHANGES:
Tue Sep 26 17:45:42 CEST 2023
+ merlin binary
- Fix issue with let operators and tuples (ocaml/merlin#1684, fixes ocaml/merlin#1683, fixes
ocaml/ocaml-lsp#1182)
- Fix an issue causing Merlin locate queries to hang (ocaml/merlin#1686,
fixes ocaml/ocaml-lsp#1192)
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Sep 26, 2023
CHANGES:
Tue Sep 26 17:45:42 CEST 2023
+ merlin binary
- Fix issue with let operators and tuples (ocaml/merlin#1684, fixes ocaml/merlin#1683, fixes
ocaml/ocaml-lsp#1182)
- Fix an issue causing Merlin locate queries to hang (ocaml/merlin#1686,
fixes ocaml/ocaml-lsp#1192)
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Sep 26, 2023
CHANGES:
Tue Sep 26 17:45:42 CEST 2023
+ merlin binary
- Fix issue with let operators and tuples (ocaml/merlin#1684, fixes ocaml/merlin#1683, fixes
ocaml/ocaml-lsp#1182)
- Fix an issue causing Merlin locate queries to hang (ocaml/merlin#1686,
fixes ocaml/ocaml-lsp#1192)
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
CHANGES:
Tue Sep 26 17:45:42 CEST 2023
+ merlin binary
- Fix issue with let operators and tuples (ocaml/merlin#1684, fixes ocaml/merlin#1683, fixes
ocaml/ocaml-lsp#1182)
- Fix an issue causing Merlin locate queries to hang (ocaml/merlin#1686,
fixes ocaml/ocaml-lsp#1192)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
let+ pat1 = ... and+ pat2 = ...are internally represented by tuples of patterns, themself encoded by a succesion of couples:[ ... [ pat1; pat2]; ...]Merlin was too eager when flattening these tuples and messed with `pat1 if it happened to be a tuple itself.
Fixes #1683
Fixes ocaml/ocaml-lsp#1182