Reproduce and fix issue #1647 with cache invalidation #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitag-ha
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
Thanks, @voodoos, that's a very nice idea for a quick fix!
In retrospective, I'm starting to regret having chosen the "ad-hoc" logic of having the PPX cache invalidation depend on the reader cache state. Marshaling the parsetree instead would make it more solid and also more flexible: with that, we could finer-grain the cache in the future from file level to structure item level, which would be some work, but would make it really impactful. The reason why I didn't choose that design was that I was wondering the same you're wondering on the issue: "I am wondering what would be the cost of marshaling the parsetree everytime however".
Co-authored-by: Sonja Heinze <[email protected]>
voodoos
added a commit
to voodoos/merlin
that referenced
this pull request
Aug 24, 2023
from voodoos/issue1647-ppx-cache-invalidation
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Aug 24, 2023
CHANGES:
Thu Aug 24 17:17:42 CEST 2023
+ merlin binary
- Constrain socket path buffer size to avoid build warnings (ocaml/merlin#1631)
- Handle concurrent server start (ocaml/merlin#1622)
- Omit module prefixes for constructors and record fields in the
`construct` command (ocaml/merlin#1618). Prefixes are still produced when
warning 42 (disambiguated name) is active.
- Correctly invalidate PPX cache when pipeline ran partially (ocaml/merlin#1650,
fixes ocaml/merlin#1647)
- Prevent `short-path` from looping in some cases related to recursive type
definitions (ocaml/merlin#1645)
- Support parsing negative numbers in sexps (ocaml/merlin#1655)
- Fix construct not working with inline records (ocaml/merlin#1658)
- Improve behavior of `type-enclosing` on let/and operators (ocaml/merlin#1653)
- Fix occurrences of extension constructors (ocaml/merlin#1662)
- Improve node selection when ghosts are present (ocaml/merlin#1664, fixes ocaml/merlin#1660)
+ editor modes
- emacs: call merlin-client-logger with "interrupted" if the
merlin binary itself is interrupted, not just the parsing of the
result (ocaml/merlin#1626).
- emacs: merlin-construct, with a prefix argument, now includes
local values in the completion options. Alternatively, this
behavior can be enabled permanently by customizing
`merlin-construct-with-local-values` (ocaml/merlin#1644)
- emacs: add support for opam-switch-mode (ocaml/merlin#1654, fixes ocaml/merlin#1591).
See <https://github.com/ProofGeneral/opam-switch-mode>
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Aug 24, 2023
CHANGES:
Thu Aug 24 17:17:42 CEST 2023
+ merlin binary
- Constrain socket path buffer size to avoid build warnings (ocaml/merlin#1631)
- Handle concurrent server start (ocaml/merlin#1622)
- Omit module prefixes for constructors and record fields in the
`construct` command (ocaml/merlin#1618). Prefixes are still produced when
warning 42 (disambiguated name) is active.
- Correctly invalidate PPX cache when pipeline ran partially (ocaml/merlin#1650,
fixes ocaml/merlin#1647)
- Prevent `short-path` from looping in some cases related to recursive type
definitions (ocaml/merlin#1645)
- Support parsing negative numbers in sexps (ocaml/merlin#1655)
- Fix construct not working with inline records (ocaml/merlin#1658)
- Improve behavior of `type-enclosing` on let/and operators (ocaml/merlin#1653)
- Fix occurrences of extension constructors (ocaml/merlin#1662)
- Improve node selection when ghosts are present (ocaml/merlin#1664, fixes ocaml/merlin#1660)
+ editor modes
- emacs: call merlin-client-logger with "interrupted" if the
merlin binary itself is interrupted, not just the parsing of the
result (ocaml/merlin#1626).
- emacs: merlin-construct, with a prefix argument, now includes
local values in the completion options. Alternatively, this
behavior can be enabled permanently by customizing
`merlin-construct-with-local-values` (ocaml/merlin#1644)
- emacs: add support for opam-switch-mode (ocaml/merlin#1654, fixes ocaml/merlin#1591).
See <https://github.com/ProofGeneral/opam-switch-mode>
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Aug 24, 2023
CHANGES:
Thu Aug 24 17:17:42 CEST 2023
+ merlin binary
- Constrain socket path buffer size to avoid build warnings (ocaml/merlin#1631)
- Handle concurrent server start (ocaml/merlin#1622)
- Omit module prefixes for constructors and record fields in the
`construct` command (ocaml/merlin#1618). Prefixes are still produced when
warning 42 (disambiguated name) is active.
- Correctly invalidate PPX cache when pipeline ran partially (ocaml/merlin#1650,
fixes ocaml/merlin#1647)
- Prevent `short-path` from looping in some cases related to recursive type
definitions (ocaml/merlin#1645)
- Support parsing negative numbers in sexps (ocaml/merlin#1655)
- Fix construct not working with inline records (ocaml/merlin#1658)
- Improve behavior of `type-enclosing` on let/and operators (ocaml/merlin#1653)
- Fix occurrences of extension constructors (ocaml/merlin#1662)
- Improve node selection when ghosts are present (ocaml/merlin#1664, fixes ocaml/merlin#1660)
+ editor modes
- emacs: call merlin-client-logger with "interrupted" if the
merlin binary itself is interrupted, not just the parsing of the
result (ocaml/merlin#1626).
- emacs: merlin-construct, with a prefix argument, now includes
local values in the completion options. Alternatively, this
behavior can be enabled permanently by customizing
`merlin-construct-with-local-values` (ocaml/merlin#1644)
- emacs: add support for opam-switch-mode (ocaml/merlin#1654, fixes ocaml/merlin#1591).
See <https://github.com/ProofGeneral/opam-switch-mode>
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Aug 24, 2023
CHANGES:
Thu Aug 24 17:17:42 CEST 2023
+ merlin binary
- Constrain socket path buffer size to avoid build warnings (ocaml/merlin#1631)
- Handle concurrent server start (ocaml/merlin#1622)
- Omit module prefixes for constructors and record fields in the
`construct` command (ocaml/merlin#1618). Prefixes are still produced when
warning 42 (disambiguated name) is active.
- Correctly invalidate PPX cache when pipeline ran partially (ocaml/merlin#1650,
fixes ocaml/merlin#1647)
- Prevent `short-path` from looping in some cases related to recursive type
definitions (ocaml/merlin#1645)
- Support parsing negative numbers in sexps (ocaml/merlin#1655)
- Fix construct not working with inline records (ocaml/merlin#1658)
- Improve behavior of `type-enclosing` on let/and operators (ocaml/merlin#1653)
- Fix occurrences of extension constructors (ocaml/merlin#1662)
- Improve node selection when ghosts are present (ocaml/merlin#1664, fixes ocaml/merlin#1660)
+ editor modes
- emacs: call merlin-client-logger with "interrupted" if the
merlin binary itself is interrupted, not just the parsing of the
result (ocaml/merlin#1626).
- emacs: merlin-construct, with a prefix argument, now includes
local values in the completion options. Alternatively, this
behavior can be enabled permanently by customizing
`merlin-construct-with-local-values` (ocaml/merlin#1644)
- emacs: add support for opam-switch-mode (ocaml/merlin#1654, fixes ocaml/merlin#1591).
See <https://github.com/ProofGeneral/opam-switch-mode>
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
CHANGES:
Thu Aug 24 17:17:42 CEST 2023
+ merlin binary
- Constrain socket path buffer size to avoid build warnings (ocaml/merlin#1631)
- Handle concurrent server start (ocaml/merlin#1622)
- Omit module prefixes for constructors and record fields in the
`construct` command (ocaml/merlin#1618). Prefixes are still produced when
warning 42 (disambiguated name) is active.
- Correctly invalidate PPX cache when pipeline ran partially (ocaml/merlin#1650,
fixes ocaml/merlin#1647)
- Prevent `short-path` from looping in some cases related to recursive type
definitions (ocaml/merlin#1645)
- Support parsing negative numbers in sexps (ocaml/merlin#1655)
- Fix construct not working with inline records (ocaml/merlin#1658)
- Improve behavior of `type-enclosing` on let/and operators (ocaml/merlin#1653)
- Fix occurrences of extension constructors (ocaml/merlin#1662)
- Improve node selection when ghosts are present (ocaml/merlin#1664, fixes ocaml/merlin#1660)
+ editor modes
- emacs: call merlin-client-logger with "interrupted" if the
merlin binary itself is interrupted, not just the parsing of the
result (ocaml/merlin#1626).
- emacs: merlin-construct, with a prefix argument, now includes
local values in the completion options. Alternatively, this
behavior can be enabled permanently by customizing
`merlin-construct-with-local-values` (ocaml/merlin#1644)
- emacs: add support for opam-switch-mode (ocaml/merlin#1654, fixes ocaml/merlin#1591).
See <https://github.com/ProofGeneral/opam-switch-mode>
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
CHANGES:
Thu Aug 24 17:17:42 CEST 2023
+ merlin binary
- Constrain socket path buffer size to avoid build warnings (ocaml/merlin#1631)
- Handle concurrent server start (ocaml/merlin#1622)
- Omit module prefixes for constructors and record fields in the
`construct` command (ocaml/merlin#1618). Prefixes are still produced when
warning 42 (disambiguated name) is active.
- Correctly invalidate PPX cache when pipeline ran partially (ocaml/merlin#1650,
fixes ocaml/merlin#1647)
- Prevent `short-path` from looping in some cases related to recursive type
definitions (ocaml/merlin#1645)
- Support parsing negative numbers in sexps (ocaml/merlin#1655)
- Fix construct not working with inline records (ocaml/merlin#1658)
- Improve behavior of `type-enclosing` on let/and operators (ocaml/merlin#1653)
- Fix occurrences of extension constructors (ocaml/merlin#1662)
- Improve node selection when ghosts are present (ocaml/merlin#1664, fixes ocaml/merlin#1660)
+ editor modes
- emacs: call merlin-client-logger with "interrupted" if the
merlin binary itself is interrupted, not just the parsing of the
result (ocaml/merlin#1626).
- emacs: merlin-construct, with a prefix argument, now includes
local values in the completion options. Alternatively, this
behavior can be enabled permanently by customizing
`merlin-construct-with-local-values` (ocaml/merlin#1644)
- emacs: add support for opam-switch-mode (ocaml/merlin#1654, fixes ocaml/merlin#1591).
See <https://github.com/ProofGeneral/opam-switch-mode>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a reproduction and a fix for issue #1647
@pitag-ha could you have a look ?