feature: add aliases for inline tests #11109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alizter
force-pushed
the
ps/rr/feature__add_aliases_for_inline_tests
branch
from
b5d5d4f to
0e1c216
Compare
hhugo
reviewed
Nov 10, 2024
Alizter
force-pushed
the
ps/rr/feature__add_aliases_for_inline_tests
branch
from
0e1c216 to
9842240
Compare
Alizter
added a commit
to Alizter/dune
that referenced
this pull request
Mar 19, 2025
This bug was noticed when working on ocaml#11109. The issue is that the cram rules create two copies of the anonymous cram action, however since the alias names are different (runtest vs cram test name) this ends up with having two different digests. This means that when building `@runtest` and `@mycram` we end up running the cram test `mycram.t` twice. This test demonstrates this behaviour. Signed-off-by: Ali Caglayan <[email protected]>
1 task
Alizter
force-pushed
the
ps/rr/feature__add_aliases_for_inline_tests
branch
2 times, most recently
from
0a26c59 to
8a845fe
Compare
Alizter
force-pushed
the
ps/rr/feature__add_aliases_for_inline_tests
branch
from
8a845fe to
6401184
Compare
|
@emillon I've updated the documentation but it could be better. Any ideas on improving it? |
Alizter
force-pushed
the
ps/rr/feature__add_aliases_for_inline_tests
branch
from
6401184 to
ef3524f
Compare
Alizter
added a commit
to Alizter/dune
that referenced
this pull request
Mar 23, 2025
This bug was noticed when working on ocaml#11109. The issue is that the cram rules create two copies of the anonymous cram action, however since the alias names are different (runtest vs cram test name) this ends up with having two different digests. This means that when building `@runtest` and `@mycram` we end up running the cram test `mycram.t` twice. This test demonstrates this behaviour. Signed-off-by: Ali Caglayan <[email protected]>
For a given library with inlines tests, we add an alias with the name of the library for running those tests. Further work on separating out the partition actions would allow us to have an alias for each partition. For now, this allows us to run inline tests with the runtest command. Signed-off-by: Ali Caglayan <[email protected]>
Alizter
force-pushed
the
ps/rr/feature__add_aliases_for_inline_tests
branch
from
ef3524f to
ff7d3da
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a given library with inlines tests, we add an alias with the name of the library for running those tests.
Further work on separating out the partition actions would allow us to have an alias for each partition.
For now, this will allow us to run inline tests with the runtest command. Further work on that will follow this PR.
This addresses part of #10239 the remaining part would be to add an alias to the
(test)stanza.