pkg: ocamlformat dev tool requires lockdir #11049
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround for an issue where dune needs to locate an ocaml toolchain in order to run `dune fmt`, and in the absence of a lockdir dune will look in PATH for ocaml tools, which may not be present. The consequence of this issue is that users of the developer preview can have an ocaml toolchain installed by dune (in their ~/.cache/dune/toolchains directory), and running `dune fmt` will complain about `ocamlc` not being found. Forcing the lockdir to exist means that dune will always take the toolchain implied by the lockdir, and there won't be a situation where the command fails due to `ocamlc` being missing. More info in this issue: ocaml#11038 Signed-off-by: Stephen Sherratt <[email protected]>
|
I was little bit surprise that ocamlformat doesn't depends on toolchains, in my mind all the dev-tools depends on toolchains. |
moyodiallo
approved these changes
Nov 5, 2024
| The project depends on ocaml, so provide a fake ocaml package: | ||
| $ make_ocaml_opam_pkg | ||
|
|
||
| The ocamlformat dev tool requires the project ot be locked: |
There was a problem hiding this comment.
Suggested change
| The ocamlformat dev tool requires the project ot be locked: | |
| The ocamlformat dev tool requires the project to be locked: |
| The project depends on ocaml, so provide a fake ocaml package: | ||
| $ make_ocaml_opam_pkg | ||
|
|
||
| The ocamlformat dev tool requires the project ot be locked: |
There was a problem hiding this comment.
Suggested change
| The ocamlformat dev tool requires the project ot be locked: | |
| The ocamlformat dev tool requires the project to be locked: |
| The project depends on ocaml, so provide a fake ocaml package: | ||
| $ make_ocaml_opam_pkg | ||
|
|
||
| The ocamlformat dev tool requires the project ot be locked: |
There was a problem hiding this comment.
Suggested change
| The ocamlformat dev tool requires the project ot be locked: | |
| The ocamlformat dev tool requires the project to be locked: |
| The project depends on ocaml, so provide a fake ocaml package: | ||
| $ make_ocaml_opam_pkg | ||
|
|
||
| The ocamlformat dev tool requires the project ot be locked: |
There was a problem hiding this comment.
Suggested change
| The ocamlformat dev tool requires the project ot be locked: | |
| The ocamlformat dev tool requires the project to be locked: |
| The project depends on ocaml, so provide a fake ocaml package: | ||
| $ make_ocaml_opam_pkg | ||
|
|
||
| The ocamlformat dev tool requires the project ot be locked: |
There was a problem hiding this comment.
Suggested change
| The ocamlformat dev tool requires the project ot be locked: | |
| The ocamlformat dev tool requires the project to be locked: |
| The project depends on ocaml, so provide a fake ocaml package: | ||
| $ make_ocaml_opam_pkg | ||
|
|
||
| The ocamlformat dev tool requires the project ot be locked: |
There was a problem hiding this comment.
Suggested change
| The ocamlformat dev tool requires the project ot be locked: | |
| The ocamlformat dev tool requires the project to be locked: |
| The project depends on ocaml, so provide a fake ocaml package: | ||
| $ make_ocaml_opam_pkg | ||
|
|
||
| The ocamlformat dev tool requires the project ot be locked: |
There was a problem hiding this comment.
Suggested change
| The ocamlformat dev tool requires the project ot be locked: | |
| The ocamlformat dev tool requires the project to be locked: |
| The project depends on ocaml, so provide a fake ocaml package: | ||
| $ make_ocaml_opam_pkg | ||
|
|
||
| The ocamlformat dev tool requires the project ot be locked: |
There was a problem hiding this comment.
Suggested change
| The ocamlformat dev tool requires the project ot be locked: | |
| The ocamlformat dev tool requires the project to be locked: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for an issue where dune needs to locate an ocaml toolchain in order to run
dune fmt, and in the absence of a lockdir dune will look in PATH for ocaml tools, which may not be present. The consequence of this issue is that users of the developer preview can have an ocaml toolchain installed by dune (in their ~/.cache/dune/toolchains directory), and runningdune fmtwill complain aboutocamlcnot being found. Forcing the lockdir to exist means that dune will always take the toolchain implied by the lockdir, and there won't be a situation where the command fails due toocamlcbeing missing.More info in this issue:
#11038