Skip to content

Add Sys.is_directory, Sys.remove and Sys.rename #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
8517a0c
Initial test of Sys.is_directory
jmid Mar 1, 2023
f135aa0
Add Sys.remove
jmid Mar 1, 2023
63b676c
add Sys.rename and refactor a bit
jmid Mar 1, 2023
d0a0804
Fix Sys.remove on directory on macOS
jmid Mar 2, 2023
afc8dcd
Fix Sys.remove on directory on Windows
jmid Mar 2, 2023
b46493f
Collect _model functions in a Model module
jmid May 24, 2023
9934fe6
Add new pp_cmd cases
jmid May 24, 2023
61a9632
Factor out path_is_an_empty_dir
jmid May 24, 2023
7f45b83
Move Model module up front
jmid May 24, 2023
0baa1d8
Factor out empty_dir
jmid May 24, 2023
b794acf
Factor out match_err
jmid May 24, 2023
421b059
Make error msg matching cases more uniform
jmid May 24, 2023
3c0907c
More uniformity: short Ok first, match on Error (Sys_error s)
jmid May 24, 2023
45faf98
Add workarounds for buggy MingW Sys.rename behaviour
jmid May 24, 2023
c5f8ef3
patch dir-to-file on MingW
jmid May 24, 2023
b6802e7
patch file-to-dir Permission denied error on MingW
jmid May 24, 2023
6c10d1f
patch dir-to-dir Sys.rename MingW regression
jmid May 24, 2023
e55bf40
Another different Sys.rename error message
jmid May 24, 2023
2999a35
Remove unused Permission-denied cases
jmid May 24, 2023
bd0b755
Remove reverse-engineering of error-message conditions
jmid Apr 19, 2024
d2e6d16
Remove OPAM workflows
jmid Apr 19, 2024
fc82574
REMOVE ME: run focused STM Sys tests
jmid Apr 19, 2024
93bfa3e
Add and clean-up existing workarounds for MSVC/MinGW Sys issues
jmid Apr 22, 2024
7bc5c94
Remove unneeded parenthesis
jmid Apr 22, 2024
fe9a5e8
REMOVE ME: enable version test on MinGW 5.0 and 5.1
jmid Apr 22, 2024
4200c04
Experiment: make Sys STM test negative across all archs
jmid Apr 23, 2024
f8dc3b9
Remove unused bindings, play with weights
jmid May 3, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/mingw-500-bytecode.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
name: MinGW bytecode 5.0.0

on:
schedule:
# Every Sunday morning, at 1:11 UTC
- cron: '11 1 * * 0'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/mingw-500.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
name: MinGW 5.0.0

on:
schedule:
# Every Sunday morning, at 1:11 UTC
- cron: '11 1 * * 0'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/mingw-51x-bytecode.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
name: MinGW bytecode 5.1

on:
schedule:
# Every Sunday morning, at 2:22 UTC
- cron: '22 2 * * 0'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/mingw-51x.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
name: MinGW 5.1

on:
schedule:
# Every Sunday morning, at 2:22 UTC
- cron: '22 2 * * 0'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
51 changes: 0 additions & 51 deletions .github/workflows/opam.yml

This file was deleted.

10 changes: 5 additions & 5 deletions dune
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
(name ci)
(package multicoretests)
(deps
(alias_rec %{env:DUNE_CI_ALIAS=runtest})))
; (alias_rec focusedtest)))
;(alias_rec %{env:DUNE_CI_ALIAS=runtest})
(alias_rec focusedtest)))

; @focusedtest
; repeat a single test a couple of times
Expand All @@ -36,7 +36,7 @@

; To change the test to repeat, change the source of the `copy`:
(rule
(copy src/io/lin_tests_domain.exe focusedtest.exe))
(copy src/sys/stm_tests.exe focusedtest.exe))

(rule
(alias focusedtest)
Expand All @@ -49,7 +49,7 @@
(write-file hoped "")
(write-file failed-runs "")
(bash
"for i in `seq 20`; do echo Starting $i-th run; if ! ./focusedtest.exe -v ; then echo $i >> failed-runs; fi; done")
"for i in `seq 10`; do echo Starting $i-th run; if ! ./focusedtest.exe -v ; then echo $i >> failed-runs; fi; done")
; edit the previous line to focus on a particular seed
(diff failed-runs hoped)))))

Expand All @@ -64,6 +64,6 @@
(write-file hoped "")
(write-file failed-runs "")
(run cmd /q /c
"for %G in (1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20) do (echo Starting %G-th run && focusedtest.exe -v || echo %G >> failed-runs)")
"for %G in (1,2,3,4,5,6,7,8,9,10) do (echo Starting %G-th run && focusedtest.exe -v || echo %G >> failed-runs)")
; edit the previous line to focus on a particular seed
(diff failed-runs hoped)))))
Loading
Loading