Skip to content

Add Sys.is_directory, Sys.remove and Sys.rename #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Add Sys.is_directory, Sys.remove and Sys.rename #304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
e2b1132
Initial test of Sys.is_directory
jmid Mar 1, 2023
5702239
Add Sys.remove
jmid Mar 1, 2023
45a894a
add Sys.rename and refactor a bit
jmid Mar 1, 2023
afd24b4
Fix Sys.remove on directory on macOS
jmid Mar 2, 2023
ce461e3
Fix Sys.remove on directory on Windows
jmid Mar 2, 2023
142a99e
Collect _model functions in a Model module
jmid May 24, 2023
dad279c
Add new pp_cmd cases
jmid May 24, 2023
602b4b4
Factor out path_is_an_empty_dir
jmid May 24, 2023
e0b0339
Move Model module up front
jmid May 24, 2023
927bcf8
Factor out empty_dir
jmid May 24, 2023
4e3ca44
Factor out match_err
jmid May 24, 2023
6a1a817
Make error msg matching cases more uniform
jmid May 24, 2023
bfa3859
More uniformity: short Ok first, match on Error (Sys_error s)
jmid May 24, 2023
e417404
Add workarounds for buggy MingW Sys.rename behaviour
jmid May 24, 2023
b8ab773
patch dir-to-file on MingW
jmid May 24, 2023
5ed0cb0
patch file-to-dir Permission denied error on MingW
jmid May 24, 2023
5a5b401
patch dir-to-dir Sys.rename MingW regression
jmid May 24, 2023
2ee78d9
Another different Sys.rename error message
jmid May 24, 2023
b8798c3
Remove unused Permission-denied cases
jmid May 24, 2023
6a56871
Remove reverse-engineering of error-message conditions
jmid Apr 19, 2024
69f1545
Add and clean-up existing workarounds for MSVC/MinGW Sys issues
jmid Apr 22, 2024
6a839b5
Remove attempt to test for sequential consistency - positively or neg…
jmid May 15, 2025
4541585
Fully qualify Model usages
jmid May 15, 2025
6f30f10
Focus on src/sys/stm_tests.exe, run 5 times
jmid May 15, 2025
46b7b81
Remove workarounds and add a note about it
jmid May 15, 2025
d9f67c0
Refactor path_is_a_file and path_is_a_dir into Model
jmid May 19, 2025
77d7365
Rework generator based on stats
jmid May 19, 2025
33b5d1f
REMOVE ME: rm gh-pages and opam workflows
jmid May 21, 2025
6782a89
REMOVE ME: trigger workflow on push
jmid May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/cygwin-530-trunk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '22 2 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/cygwin-540-trunk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '33 3 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/cygwin-550-trunk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '44 4 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
42 changes: 0 additions & 42 deletions .github/workflows/gh-pages.yml
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions .github/workflows/linux-530-trunk-32bit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '22 2 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/linux-530-trunk-arm64.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '22 2 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/linux-530-trunk-bytecode.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '22 2 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/linux-530-trunk-debug.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '22 2 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/linux-530-trunk-fp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '22 2 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/linux-530-trunk-musl.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '22 2 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/linux-530-trunk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '22 2 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/linux-540-trunk-32bit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '33 3 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/linux-540-trunk-arm64.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '33 3 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/linux-540-trunk-bytecode.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '33 3 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/linux-540-trunk-debug.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '33 3 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/linux-540-trunk-fp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '33 3 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/linux-540-trunk-musl.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '33 3 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/linux-540-trunk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '33 3 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/linux-550-trunk-32bit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '44 4 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/linux-550-trunk-arm64.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '44 4 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/linux-550-trunk-bytecode.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '44 4 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/linux-550-trunk-debug.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '44 4 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/linux-550-trunk-fp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '44 4 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/linux-550-trunk-musl.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '44 4 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/linux-550-trunk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '44 4 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/macosx-arm64-530-trunk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '22 2 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/macosx-arm64-540-trunk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '33 3 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/macosx-arm64-550-trunk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '44 4 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/macosx-intel-530-trunk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '22 2 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/macosx-intel-540-trunk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '33 3 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/macosx-intel-550-trunk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '44 4 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/mingw-530-trunk-bytecode.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '22 2 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/mingw-530-trunk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '22 2 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/mingw-540-trunk-bytecode.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '33 3 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/mingw-540-trunk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '33 3 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/mingw-550-trunk-bytecode.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '44 4 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/mingw-550-trunk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '44 4 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/msvc-530-trunk-bytecode.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '22 2 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/msvc-530-trunk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '22 2 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/msvc-540-trunk-bytecode.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- cron: '33 3 * * 1'
pull_request:
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down
Loading
Loading