Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fs implementation for windows #509

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

patricoferris
Copy link
Collaborator

A WIP PR built on top of #497 adding support for filesystem operations primarily using NtCreateFile which apparently is the closest thing to openat that Windows has to offer.

@polytypic
Copy link
Contributor

I tried this on my Windows machine and the symlink test seemed to fail. I assume that is expected? (I'll take a closer look through the code.)

@patricoferris
Copy link
Collaborator Author

Still WIP, I'll be revisiting it this weekend, but thanks for taking a look already!

@talex5 talex5 added this to the 0.11 milestone May 31, 2023
@talex5
Copy link
Collaborator

talex5 commented Jun 2, 2023

I squashed and rebased this PR on main, which should fix the unrelated CI errors. I'd like to do an Eio 0.10 release, and this is the only remaining issue for it. We could either release without FS support, or merge this as it is and let people fix the missing bits. Any reason not to merge?

@patricoferris
Copy link
Collaborator Author

Any reason not to merge?

Apart from it potentially being a bit broken particularly with the symlinking behaviour and missing functionality like pread. But, perhaps a windows backend in the wild will lower the barrier to trying it out and then getting fixes from people?

@talex5 talex5 marked this pull request as ready for review June 2, 2023 09:38
@talex5
Copy link
Collaborator

talex5 commented Jun 2, 2023

Sounds good. We can document eio_windows as being incomplete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants