Read gospel files #196
Open
Read gospel files #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-osborne
force-pushed
the
read-gospel-file
branch
3 times, most recently
from
d0a9a54
to
17ef796
Compare
n-osborne
force-pushed
the
read-gospel-file
branch
from
17ef796
to
a52fd59
Compare
n-osborne
force-pushed
the
read-gospel-file
branch
4 times, most recently
from
917435b
to
deb70ab
Compare
n-osborne
force-pushed
the
read-gospel-file
branch
from
deb70ab
to
000f318
Compare
|
Rebased on #218, please consider only the last six commits. |
n-osborne
force-pushed
the
read-gospel-file
branch
2 times, most recently
from
c684ec4
to
953406c
Compare
n-osborne
force-pushed
the
read-gospel-file
branch
2 times, most recently
from
9aeb63d
to
8d537c0
Compare
|
This PR could also include an update of the dune plugin to make it read the gospel file. Edit: let's do that in another PR. |
n-osborne
force-pushed
the
read-gospel-file
branch
3 times, most recently
from
e9aa01e
to
acd4df3
Compare
n-osborne
force-pushed
the
read-gospel-file
branch
from
acd4df3
to
06101b2
Compare
n-osborne
force-pushed
the
read-gospel-file
branch
from
06101b2
to
998964c
Compare
FIXME: generated code is broken on tuple translation
n-osborne
force-pushed
the
read-gospel-file
branch
from
998964c
to
6970d94
Compare
|
Apparently, reading from the pre-checked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to use the gospel (yet unmerged) new feature from #376.
Some refactoring is done a long the way (there may be room for more, but I was mainly interested - at least at first - in experimenting and see how to use the new features in the examples.
This PR only add reading the
.gospelfiles for theqcheck-stmplugin, as it is an experimentation. But this allows to see how it goes with the dune rules in theexamples/directory.Note that this PR is also based on #380.