Avoid sets of simples #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
poechsel
reviewed
Apr 2, 2021
|
Could we enhance this to actually remove |
lukemaurer
force-pushed
the
avoid-sets-of-simples
branch
from
feb94a6 to
d832a12
Compare
lukemaurer
force-pushed
the
avoid-sets-of-simples
branch
from
bd4dad1 to
27cce55
Compare
|
Anyone know why the tests aren't running for this? @mshinwell? Should be ready for final review and merge otherwise |
|
@lukemaurer I think it's because you need to rebase, there is a conflict |
A `Name.Set.t` or `'a Name.Map.t` is a fine thing, but a `Simple.Set.t` or `'a Simple.Map.t` is much sketchier, since whether we want to treat two simples that differ only in `Rec_info.t` as equivalent depends on context. Fortunately, we usually just need a set or map of names. The one place where this gets tricky is in the uses of `Aliases.get_alias`, so there's now `Aliases.Alias_set.t` to encapsulate the needed operations.
Everything is now gone except for a few stragglers in `cmx/` and `naming/`; these will be more easily dealt with after some changes to `Simple.t`.
lukemaurer
force-pushed
the
avoid-sets-of-simples
branch
from
27cce55 to
7f1dec6
Compare
Rebased (freaking |
request-checks: true
poechsel
requested changes
Apr 28, 2021
poechsel
reviewed
Apr 30, 2021
Actually making the change (which would require significantly refactoring `Typing_env.add_equation`) is outside the scope of this PR.
|
I agree to merge if the |
poechsel
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
Name.Set.tor'a Name.Map.tis a fine thing, but aSimple.Set.tor
'a Simple.Map.tis much sketchier, since whether we want to treattwo simples that differ only in
Rec_info.tas equivalent depends oncontext. Fortunately, we usually just need a set or map of names. The
one place where this gets tricky is in the uses of
Aliases.get_alias,so there's now
Aliases.Alias_set.tto encapsulate the neededoperations.