Remove @no_mutable_implied_modalities
#3962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riaqn
force-pushed
the
refactor-modality-const-repr
branch
from
2f81160 to
f37af34
Compare
dkalinichenko-js
force-pushed
the
refactor-modality-const-repr
branch
2 times, most recently
from
f852f50 to
aa8de35
Compare
riaqn
force-pushed
the
refactor-modality-const-repr
branch
from
57a5d4b to
bf120a4
Compare
riaqn
force-pushed
the
remove-no-mutable-implied-modalities
branch
from
2a973e5 to
1220987
Compare
|
In the process of reviewing this, I realized I wanted documentation around the semantics of modalities -- mostly so that I could check that the implementation met that specification. But we don't have any documentation! However, I don't think it makes sense to add this as part of this patch. Instead, I have added a note within #3943 to add more documentation when we fix a CR in that PR. (No action needed in response, just noting the connection to #3943.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #3961, we no longer need this attribute - we can write out modalities to override the
mutable-implied ones.