Modality.Value.Const
should behave like a product
#3961
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #3949
This PR refactors the interface of
Modality.Value.Const
to make it behave like a product of axes (that you can project and update specific axis) instead of a sequence of atoms (that you compose).This allows other incoming PRs that do the following:
[@no_mutable_implied_modalities]
, since we can spell out modalities to override thoseportable
withportable
)Review
@dkalinichenko-js , could you look at the changes in
typemode.ml
and tests. In particular, could you check that the implication and the print back is still as expected. Feel free to add more tests.