Skip to content

Remove more fields from Reg.t #3838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 11, 2025
Merged

Remove more fields from Reg.t #3838

merged 9 commits into from
Apr 11, 2025

Conversation

xclerc
Copy link
Contributor

@xclerc xclerc commented Apr 10, 2025 •
edited
Loading

This pull request is a follow-up to #3835,
removing more fields from Reg.t (namely
spill and spill_cost).

@xclerc xclerc added the backend label Apr 10, 2025
@xclerc xclerc marked this pull request as ready for review April 11, 2025 09:15
@xclerc xclerc changed the title Remove more fields from Reg.t Remove more fields from Reg.t Apr 11, 2025
spiessimon
spiessimon reviewed Apr 11, 2025
View reviewed changes
Copy link
Contributor

@spiessimon spiessimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect I'm missing something. I did not find the code that actually does the spilling now, but probably I just did not know where to look.

spiessimon
spiessimon approved these changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@spiessimon spiessimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying my confusions. Looks good to me!

Base automatically changed from irc-spilled to main April 11, 2025 14:46
@xclerc xclerc force-pushed the reg-remove-more-fields branch from f3845c8 to f5e29f5 Compare April 11, 2025 14:58
@xclerc xclerc merged commit fa5fb60 into main Apr 11, 2025
26 checks passed
@xclerc xclerc deleted the reg-remove-more-fields branch April 11, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiessimon spiessimon spiessimon approved these changes

Assignees
No one assigned
Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xclerc @spiessimon