-
Notifications
You must be signed in to change notification settings - Fork 85
Downstreams for renaming #3828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Downstreams for renaming #3828
Conversation
voodoos
commented
Apr 8, 2025
•
edited
Loading
edited
- Distinguish uids from interfaces and implementations: [tooling] Distinct uids for interfaces ocaml/ocaml#13286
- Linked related declarations together: [tooling] Remember linked declarations ocaml/ocaml#13308
75efadc
to
5076bb0
Compare
5076bb0
to
919b045
Compare
@lukemaurer what do you think would be the best way to handle the additionnal information in bcfebba ? In the upstream compiler, we now store a |
29f9e96
to
6f67595
Compare
4de6e71
to
1cf2d36
Compare
@lukemaurer I'd like to discuss the |
6d2f7d2
to
7ca7182
Compare
Keep merge conflicts [tooling] Distinct uids for interfaces
[tooling] Distinct uids for interfaces There should be a cleaner way to store the additional information. Upstream this info is part of a `Unit_info.t` record that is stored as the "current unit" in the environement. But here in flambda-backend it is `Compilation_unit.t` instead. This looks like conflicting refactorings that it would be useful to reconcile. Here, for the prototype, we use a tuple to add that information.
Keep git conflicts [tooling] Remember linked declarations
[tooling] Remember linked declarations
7ca7182
to
cb9cf1d
Compare
Hmm. I think it would make more sense to do what we've been intending to do for a while and have (Ultimately I'm not sure that |