Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize and improve debugging for with-kinds #3630

Merged
merged 32 commits into from
Mar 5, 2025
Merged

Optimize and improve debugging for with-kinds #3630

merged 32 commits into from
Mar 5, 2025

Conversation

goldfirere
Copy link
Collaborator

No description provided.

@goldfirere goldfirere force-pushed the rae/optimize-normalize branch 3 times, most recently from b4d84c6 to 4b80ac5 Compare March 3, 2025 14:32
@goldfirere
Copy link
Collaborator Author

@ccasin: could you please review this commit ? That's the outcome of this afternoon's conversation.

@ccasin
Copy link
Contributor

ccasin commented Mar 4, 2025

@ccasin: could you please review this commit ? That's the outcome of this afternoon's conversation.

LGTM

@glittershark glittershark self-requested a review March 4, 2025 16:42
glittershark
glittershark requested changes Mar 4, 2025
View reviewed changes
Copy link
Member

@glittershark glittershark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed the current set of commits (up to "Deal correctly with open types after unboxing")

@glittershark glittershark force-pushed the rae/optimize-normalize branch from 1085b58 to e9b4de4 Compare March 4, 2025 19:12
@glittershark
Copy link
Member

Force pushed with a rebase on main

@glittershark glittershark changed the title Test the latest attempt at with kinds (with inference) Optimize and improve debugging for with-kinds Mar 5, 2025
@glittershark glittershark marked this pull request as ready for review March 5, 2025 14:28
@glittershark glittershark force-pushed the rae/optimize-normalize branch from d51de17 to 6605120 Compare March 5, 2025 14:28
@glittershark
Copy link
Member

glittershark commented Mar 5, 2025 •
edited
Loading

glittershark
glittershark approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@glittershark glittershark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than that, this lgtm.

goldfirere
goldfirere commented Mar 5, 2025
View reviewed changes
goldfirere and others added 17 commits March 5, 2025 10:49
@goldfirere @glittershark
Unconditionally print with-bounds, accepting new output
c546cfc
@goldfirere @glittershark
Strip out support for normalization during printing
5ac2ad3
@goldfirere @glittershark
Make printing types easier
998955c
@goldfirere @glittershark
Short-circuit when no axes are relevant
e33fb01
@goldfirere @glittershark
Get all the modal bounds in one big go.
a223e48
@goldfirere @glittershark
Avoid map_type_expr in common case
ebf0110
@goldfirere @glittershark
More debugging support
be3f7d7
@goldfirere @glittershark
Improve CR comment on failing test case
4f96795
@goldfirere @glittershark
Deal correctly with open types after unboxing
7537591
@glittershark
Document mod-bounds functions
ba91376
@glittershark
more docs for is_obviously_max
14ec165
@glittershark
Update comment in typing/jkind.ml
07ec2c4
@glittershark
wrap a comment
3a84747
@glittershark
relevant_axes -> skip_axes
40b82ba 
This difference, perhaps somewhat surprisingly, shows up on a (very quick)
profile!
@glittershark
promote, after re-disabling inference
0840b9e
@glittershark
fixes for relevant_axes->skip_axes
70d4687
@glittershark
promote failures after rebase
2a30b5c
@glittershark glittershark force-pushed the rae/optimize-normalize branch from 3978767 to 2a30b5c Compare March 5, 2025 15:53
@glittershark glittershark enabled auto-merge (squash) March 5, 2025 15:55
@glittershark glittershark merged commit 29c4fc1 into ocaml-flambda:main Mar 5, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glittershark glittershark glittershark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goldfirere @ccasin @glittershark