-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename Json Files #315
Open
codeamic
wants to merge
12
commits into
ocaml-bench:main
Choose a base branch
from
codeamic:RenameJsonFile
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
rename Json Files #315
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f56963e
rename Json Files
codeamic e8eda9e
update
codeamic 5ec897e
updates
codeamic abf4ee4
update
codeamic 2116db0
updates
codeamic 4fa2829
update
codeamic 28ad010
update
codeamic 1c310af
update
codeamic 0f768f6
updated changes
codeamic 2821c7b
updated lines 48 and 101
codeamic 013212f
Merge branch 'main' of https://github.com/ocaml-bench/sandmark into R…
codeamic 543030d
Deleted drone CI to be mergeable on main
ElectreAAS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The filtered files should also be changed to their new names. Leave the
filtered
as such and edit the name. This needs to be updated in therun_all*
scripts too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Sudha, thank you for the support, i just did the new changes but couldn't find the run_config_filtered.json file itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! You're right,
run_config_filtered.json
is created only after we runTAG='"macro_bench"' make run_config_filtered.json
, so no need to modify that file.Are you able to repeat this process for the other three files, like for example
run_all_parallel.sh
hasmulticore_parallel_run_config_filtered.json
.git grep
command should help here too. :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah i did git grep run_config.json, you could see the changes in all the files. i made sure i changed that in all files. could you please check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry if it was unclear; what I meant is the same process of replacing
*_filtered.json
with the new file name needs to be done formulticore_parallel_run_config_filtered.json
, i.e it will be calledparallel_turing_filtered.json
andmulticore_parallel_navajo_run_config_filtered.json
will beparallel_navajo_filtered.json
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Sudha, no worries i just made the changes
could you please review?
Also, there is this file multicore_parallel_run_config_filtered_filtered_2domains, does it need renaming?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Yes, we can call it
parallel_turing_filtered_filtered_2domains.json
. You can see how it's generated here: https://github.com/ocaml-bench/sandmark/blob/main/Makefile#L347-L348. This should make the CI happy I think. You might also want to edit thedrone.yml
file with the latest names.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Sudha, thank you so much for your endless support, i just did the changes and modified the drone.yml file too. please review for merge or correction of errors, thank you.