Create new cron jobs for anonymisation warnings #128
Conversation
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @faucomte97)
cron.yaml line 94 at r1 (raw file):
# /cron/user/inactive/send-third-reminder/ - url: /cron/user/inactive/send-third-reminder/
is it send-third or send-final?
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @faucomte97)
cron.yaml line 181 at r1 (raw file):
target: production-portal # /api/cron/user/inactive/send-first-reminder/
These routes are not correct. In the new system it will be
"/api/users/{action}"
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @faucomte97)
cron.yaml line 110 at r1 (raw file):
# ---------------------------------------------------------------------------- # New system
please add a todo to fix all cron urls in the new system. these are all wrong
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @faucomte97)
cron.yaml line 181 at r1 (raw file):
target: production-portal # /api/cron/user/inactive/send-first-reminder/
these urls are incorrect. should be:
/api/users/cron/{action}/
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @faucomte97)
cron.yaml line 181 at r1 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
these urls are incorrect. should be:
/api/users/cron/{action}/
also, you used the wrong action names in these urls
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @faucomte97 and @SKairinos)
cron.yaml line 94 at r1 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
is it send-third or send-final?
Final it shall be
cron.yaml line 110 at r1 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
please add a todo to fix all cron urls in the new system. these are all wrong
Done.
cron.yaml line 181 at r1 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
also, you used the wrong action names in these urls
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 25 unresolved discussions (waiting on @faucomte97)
cron.yaml line 131 at r2 (raw file):
target: production-sso # /api/users/cron/send_1st_verify_email_reminder/
-
urls are always kebab case in new system, not snake case. fix everywhere.
-
cron urls must always be unique. or else how would it know which service to route the request to?
-
Also you must always prepend the url with the target's name except for production-portal (special case since it's the 'root' service).
cron.yaml line 131 at r2 (raw file):
target: production-sso # /api/users/cron/send_1st_verify_email_reminder/
/api/users/cron/send-1st-verify-email-reminder/
cron.yaml line 133 at r2 (raw file):
# /api/users/cron/send_1st_verify_email_reminder/ - url: /api/users/cron/send_1st_verify_email_reminder/
/development-portal/api/users/cron/send-1st-verify-email-reminder/
cron.yaml line 138 at r2 (raw file):
target: development-portal - url: /api/users/cron/send_1st_verify_email_reminder/
/staging-portal/api/users/cron/send-1st-verify-email-reminder/
cron.yaml line 143 at r2 (raw file):
target: staging-portal - url: /api/users/cron/send_1st_verify_email_reminder/
/api/users/cron/send-1st-verify-email-reminder/
cron.yaml line 148 at r2 (raw file):
target: production-portal # /api/users/cron/send_2nd_verify_email_reminder/
please fix
cron.yaml line 150 at r2 (raw file):
# /api/users/cron/send_2nd_verify_email_reminder/ - url: /api/users/cron/send_2nd_verify_email_reminder/
please fix
cron.yaml line 155 at r2 (raw file):
target: development-portal - url: /api/users/cron/send_2nd_verify_email_reminder/
please fix
cron.yaml line 160 at r2 (raw file):
target: staging-portal - url: /api/users/cron/send_2nd_verify_email_reminder/
please fix
cron.yaml line 165 at r2 (raw file):
target: production-portal # /api/users/cron/anonymize_unverified_accounts/
please fix
cron.yaml line 167 at r2 (raw file):
# /api/users/cron/anonymize_unverified_accounts/ - url: /api/users/cron/anonymize_unverified_accounts/
please fix
cron.yaml line 172 at r2 (raw file):
target: development-portal - url: /api/users/cron/anonymize_unverified_accounts/
please fix
cron.yaml line 177 at r2 (raw file):
target: staging-portal - url: /api/users/cron/anonymize_unverified_accounts/
please fix
cron.yaml line 182 at r2 (raw file):
target: production-portal # /api/users/cron/send_1st_inactivity_reminder/
please fix
cron.yaml line 184 at r2 (raw file):
# /api/users/cron/send_1st_inactivity_reminder/ - url: /api/users/cron/send_1st_inactivity_reminder/
please fix
cron.yaml line 189 at r2 (raw file):
target: development-portal - url: /api/users/cron/send_1st_inactivity_reminder/
please fix
cron.yaml line 194 at r2 (raw file):
target: staging-portal - url: /api/users/cron/send_1st_inactivity_reminder/
please fix
cron.yaml line 199 at r2 (raw file):
target: production-portal # /api/users/cron/send_2nd_inactivity_reminder/
please fix
cron.yaml line 201 at r2 (raw file):
# /api/users/cron/send_2nd_inactivity_reminder/ - url: /api/users/cron/send_2nd_inactivity_reminder/
please fix
cron.yaml line 206 at r2 (raw file):
target: development-portal - url: /api/users/cron/send_2nd_inactivity_reminder/
please fix
cron.yaml line 211 at r2 (raw file):
target: staging-portal - url: /api/users/cron/send_2nd_inactivity_reminder/
please fix
cron.yaml line 216 at r2 (raw file):
target: production-portal # /api/users/cron/send_final_inactivity_reminder/
please fix
cron.yaml line 218 at r2 (raw file):
# /api/users/cron/send_final_inactivity_reminder/ - url: /api/users/cron/send_final_inactivity_reminder/
please fix
cron.yaml line 223 at r2 (raw file):
target: development-portal - url: /api/users/cron/send_final_inactivity_reminder/
please fix
cron.yaml line 228 at r2 (raw file):
target: staging-portal - url: /api/users/cron/send_final_inactivity_reminder/
please fix
There was a problem hiding this comment.
Reviewable status: all files reviewed, 25 unresolved discussions (waiting on @SKairinos)
cron.yaml line 131 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
/api/users/cron/send-1st-verify-email-reminder/
Done.
cron.yaml line 131 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
urls are always kebab case in new system, not snake case. fix everywhere.
cron urls must always be unique. or else how would it know which service to route the request to?
Also you must always prepend the url with the target's name except for production-portal (special case since it's the 'root' service).
Done.
cron.yaml line 133 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
/development-portal/api/users/cron/send-1st-verify-email-reminder/
Done.
cron.yaml line 138 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
/staging-portal/api/users/cron/send-1st-verify-email-reminder/
Done.
cron.yaml line 143 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
/api/users/cron/send-1st-verify-email-reminder/
Done.
cron.yaml line 148 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
please fix
Done.
cron.yaml line 150 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
please fix
Done.
cron.yaml line 155 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
please fix
Done.
cron.yaml line 160 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
please fix
Done.
cron.yaml line 165 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
please fix
Done.
cron.yaml line 167 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
please fix
Done.
cron.yaml line 172 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
please fix
Done.
cron.yaml line 177 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
please fix
Done.
cron.yaml line 182 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
please fix
Done.
cron.yaml line 184 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
please fix
Done.
cron.yaml line 189 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
please fix
Done.
cron.yaml line 194 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
please fix
Done.
cron.yaml line 199 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
please fix
Done.
cron.yaml line 201 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
please fix
Done.
cron.yaml line 206 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
please fix
Done.
cron.yaml line 211 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
please fix
Done.
cron.yaml line 216 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
please fix
Done.
cron.yaml line 218 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
please fix
Done.
cron.yaml line 223 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
please fix
Done.
cron.yaml line 228 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
please fix
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @faucomte97)
This change is