-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use WIF instead of service account key #119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @faucomte97)
.github/workflows/backend.yaml
line 27 at r1 (raw file):
source-path: src deploy:
please add the following:
permissions:
id-token: 'write' # TODO: separate build and deploy jobs and create reusable deploy workflow
.github/workflows/cron.yaml
line 12 at r1 (raw file):
jobs: deploy:
please add the following:
permissions:
id-token: 'write' # TODO: separate build and deploy jobs and create reusable deploy workflow
.github/workflows/dispatch.yaml
line 12 at r1 (raw file):
jobs: deploy:
please add the following:
permissions:
id-token: 'write' # TODO: separate build and deploy jobs and create reusable deploy workflow
.github/workflows/frontend.yaml
line 26 at r1 (raw file):
node-version: ${{ inputs.node-version }} deploy:
please add the following:
permissions:
id-token: 'write' # TODO: separate build and deploy jobs and create reusable deploy workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @SKairinos)
.github/workflows/backend.yaml
line 27 at r1 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
please add the following:
permissions: id-token: 'write' # TODO: separate build and deploy jobs and create reusable deploy workflow
Done.
.github/workflows/cron.yaml
line 12 at r1 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
please add the following:
permissions: id-token: 'write' # TODO: separate build and deploy jobs and create reusable deploy workflow
Done.
.github/workflows/dispatch.yaml
line 12 at r1 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
please add the following:
permissions: id-token: 'write' # TODO: separate build and deploy jobs and create reusable deploy workflow
Done.
.github/workflows/frontend.yaml
line 26 at r1 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
please add the following:
permissions: id-token: 'write' # TODO: separate build and deploy jobs and create reusable deploy workflow
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)
This change is